Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2965803002: Move more printing code off of the FILE thread. (Closed)

Created:
3 years, 5 months ago by Lei Zhang
Modified:
3 years, 5 months ago
Reviewers:
fdoray
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move more printing code off of the FILE thread. Do some trivial cleanups while we are here. BUG=689520 Review-Url: https://codereview.chromium.org/2965803002 Cr-Commit-Position: refs/heads/master@{#483845} Committed: https://chromium.googlesource.com/chromium/src/+/c0d6f887d2fef1a66b612b3dbf4869f26b571695

Patch Set 1 #

Patch Set 2 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -28 lines) Patch
M chrome/browser/printing/print_dialog_cloud_win.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/printing/printer_manager_dialog_linux.cc View 3 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/printing/printer_manager_dialog_win.cc View 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Lei Zhang
3 years, 5 months ago (2017-06-30 22:08:28 UTC) #8
fdoray
lgtm
3 years, 5 months ago (2017-06-30 22:13:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2965803002/20001
3 years, 5 months ago (2017-06-30 22:26:43 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 22:30:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c0d6f887d2fef1a66b612b3dbf48...

Powered by Google App Engine
This is Rietveld 408576698