runtime/vm/stub_code_ia32.cc - Issue 2965723002: VM: Reland Inline instance object hash code into object header on 64bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 2965723002: VM: Reland Inline instance object hash code into object header on 64bit. (Closed)

Patch Set: Fix snapshot incompatibility that sank Flutter Gallery Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/stub_code_ia32.cc

diff --git a/runtime/vm/stub_code_ia32.cc b/runtime/vm/stub_code_ia32.cc

index 5004b0171670dec6f8789ff42d6e87817a5a05eb..240d1fd19025736ee9315d29a9c07ba5141e1557 100644

--- a/runtime/vm/stub_code_ia32.cc

+++ b/runtime/vm/stub_code_ia32.cc

@@ -1078,7 +1078,7 @@ void StubCode::GenerateAllocationStubForClass(Assembler* assembler,

// EBX: next object start.

// EDX: new object type arguments (if is_cls_parameterized).

// Set the tags.

- uword tags = 0;

+ uint32_t tags = 0;

tags = RawObject::SizeTag::update(instance_size, tags);

ASSERT(cls.id() != kIllegalCid);

tags = RawObject::ClassIdTag::update(cls.id(), tags);