Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: runtime/vm/stub_code_ia32.cc

Issue 2965723002: VM: Reland Inline instance object hash code into object header on 64bit. (Closed)
Patch Set: Fix snapshot incompatibility that sank Flutter Gallery Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/compiler.h" 9 #include "vm/compiler.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1060 matching lines...) Expand 10 before | Expand all | Expand 10 after
1071 } else { 1071 } else {
1072 __ j(ABOVE_EQUAL, &slow_case); 1072 __ j(ABOVE_EQUAL, &slow_case);
1073 } 1073 }
1074 __ movl(Address(EDI, Heap::TopOffset(space)), EBX); 1074 __ movl(Address(EDI, Heap::TopOffset(space)), EBX);
1075 NOT_IN_PRODUCT(__ UpdateAllocationStats(cls.id(), ECX, space)); 1075 NOT_IN_PRODUCT(__ UpdateAllocationStats(cls.id(), ECX, space));
1076 1076
1077 // EAX: new object start (untagged). 1077 // EAX: new object start (untagged).
1078 // EBX: next object start. 1078 // EBX: next object start.
1079 // EDX: new object type arguments (if is_cls_parameterized). 1079 // EDX: new object type arguments (if is_cls_parameterized).
1080 // Set the tags. 1080 // Set the tags.
1081 uword tags = 0; 1081 uint32_t tags = 0;
1082 tags = RawObject::SizeTag::update(instance_size, tags); 1082 tags = RawObject::SizeTag::update(instance_size, tags);
1083 ASSERT(cls.id() != kIllegalCid); 1083 ASSERT(cls.id() != kIllegalCid);
1084 tags = RawObject::ClassIdTag::update(cls.id(), tags); 1084 tags = RawObject::ClassIdTag::update(cls.id(), tags);
1085 __ movl(Address(EAX, Instance::tags_offset()), Immediate(tags)); 1085 __ movl(Address(EAX, Instance::tags_offset()), Immediate(tags));
1086 __ addl(EAX, Immediate(kHeapObjectTag)); 1086 __ addl(EAX, Immediate(kHeapObjectTag));
1087 1087
1088 // Initialize the remaining words of the object. 1088 // Initialize the remaining words of the object.
1089 1089
1090 // EAX: new object (tagged). 1090 // EAX: new object (tagged).
1091 // EBX: next object start. 1091 // EBX: next object start.
(...skipping 1044 matching lines...) Expand 10 before | Expand all | Expand 10 after
2136 } 2136 }
2137 2137
2138 2138
2139 void StubCode::GenerateAsynchronousGapMarkerStub(Assembler* assembler) { 2139 void StubCode::GenerateAsynchronousGapMarkerStub(Assembler* assembler) {
2140 __ int3(); 2140 __ int3();
2141 } 2141 }
2142 2142
2143 } // namespace dart 2143 } // namespace dart
2144 2144
2145 #endif // defined TARGET_ARCH_IA32 2145 #endif // defined TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698