Mojo C++ bindings: support setting default value for fields whose types are typemapped enums.

Mojo C++ bindings: support setting default value for fields whose types are typemapped enums.

BUG=738142
Review-Url: https://codereview.chromium.org/2965663002
Cr-Commit-Position: refs/heads/master@{#483561}
Committed: https://chromium.googlesource.com/chromium/src/+/dc674b50f259153e15e9f1df37b320f4ffdb41bc

[yzshen1, 2017-06-29 22:46:32]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 22:46:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2017-06-29 22:47:28]

yzshen@chromium.org changed reviewers:
+ rockot@chromium.org

[yzshen1, 2017-06-29 22:47:29]

Hi, Ken.

Would you please take a look? Thanks!

[yzshen1, 2017-06-29 22:48:07]

Hi, Randy.

FYI.

[Ken Rockot(use gerrit already), 2017-06-29 22:49:39]

lgtm

https://codereview.chromium.org/2965663002/diff/1/mojo/public/cpp/bindings/li...
File mojo/public/cpp/bindings/lib/bindings_internal.h (right):

https://codereview.chromium.org/2965663002/diff/1/mojo/public/cpp/bindings/li...
mojo/public/cpp/bindings/lib/bindings_internal.h:338: CHECK(result);
nit: I think we should limit this to DCHECK given that I don't think it's a
critical security bug for someone to initialize an enum with a bad value.

[yzshen1, 2017-06-29 22:51:40]

Thanks for quick review!

https://codereview.chromium.org/2965663002/diff/1/mojo/public/cpp/bindings/li...
File mojo/public/cpp/bindings/lib/bindings_internal.h (right):

https://codereview.chromium.org/2965663002/diff/1/mojo/public/cpp/bindings/li...
mojo/public/cpp/bindings/lib/bindings_internal.h:338: CHECK(result);
On 2017/06/29 22:49:39, Ken Rockot(use gerrit already) wrote:
> nit: I think we should limit this to DCHECK given that I don't think it's a
> critical security bug for someone to initialize an enum with a bad value.

Done.

[yzshen1, 2017-06-29 22:51:59]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2017-06-29 22:51:59]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2965663002/#ps20001
(title: ".")

[commit-bot: I haz the power, 2017-06-29 22:52:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 00:33:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498776719630530,
"parent_rev": "71911249cfd027e31384c7daa1a781773545036c", "commit_rev":
"dc674b50f259153e15e9f1df37b320f4ffdb41bc"}

[commit-bot: I haz the power, 2017-06-30 00:33:24]

Description was changed from

==========
Mojo C++ bindings: support setting default value for fields whose types are
typemapped enums.

BUG=738142
==========

to

==========
Mojo C++ bindings: support setting default value for fields whose types are
typemapped enums.

BUG=738142

Review-Url: https://codereview.chromium.org/2965663002
Cr-Commit-Position: refs/heads/master@{#483561}
Committed:
https://chromium.googlesource.com/chromium/src/+/dc674b50f259153e15e9f1df37b3...
==========

[commit-bot: I haz the power, 2017-06-30 00:33:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dc674b50f259153e15e9f1df37b3...