Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2965633002: Fix handling of inline JS types in DDC. (Closed)

Created:
3 years, 5 months ago by Leaf
Modified:
3 years, 5 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix handling of inline JS types in DDC. DDC was incorrectly interpreting inline JS types, and hence marking some things as non-nullable which were nullable. This fixes that, and also slightly improves the analyzers treatment of inline JS types. Also fixes some incorrect inline JS type annotations in DDC patch files. BUG= R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/24f94785502bed25030acb98f64edd5ce5c20eee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/src/compiler/nullable_type_inference.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Leaf
3 years, 5 months ago (2017-06-29 21:47:47 UTC) #2
vsm
lgtm
3 years, 5 months ago (2017-06-29 22:57:43 UTC) #3
Leaf
3 years, 5 months ago (2017-06-29 23:02:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
24f94785502bed25030acb98f64edd5ce5c20eee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698