pkg/dev_compiler/tool/input_sdk/private/js_helper.dart - Issue 2965633002: Fix handling of inline JS types in DDC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/js_helper.dart

Issue 2965633002: Fix handling of inline JS types in DDC. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/dev_compiler/tool/input_sdk/private/js_helper.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/private/js_helper.dart b/pkg/dev_compiler/tool/input_sdk/private/js_helper.dart

index 131aa180c1221305487c7ebf752e81fedf8ae9c7..0017ebc9b16877df510e6ab71c831789f1b79945 100644

--- a/pkg/dev_compiler/tool/input_sdk/private/js_helper.dart

+++ b/pkg/dev_compiler/tool/input_sdk/private/js_helper.dart

@@ -624,7 +624,7 @@ class UnknownJsTypeError extends Error {

final _stackTrace = JS('', 'Symbol("_stackTrace")');

StackTrace getTraceFromException(exception) {

var error = JS('', 'dart.recordJsError(#)', exception);

- var trace = JS('StackTrace', '#[#]', error, _stackTrace);

+ var trace = JS('StackTrace|Null', '#[#]', error, _stackTrace);

if (trace != null) return trace;

trace = new _StackTrace(error);

JS('', '#[#] = #', error, _stackTrace, trace);