Move Map/Set to allowed features of ES6 styleguide.

Move Map/Set to allowed features of ES6 styleguide.

Also remove backticks from markdown headers because they cause everything
between the backticks to not render in the TOC.

BUG=None

Review-Url: https://codereview.chromium.org/2965543002
Cr-Commit-Position: refs/heads/master@{#483534}
Committed: https://chromium.googlesource.com/chromium/src/+/0f7c30871c4eb669bedfa348035bb5fb21c91746

[dpapad, 2017-06-29 17:42:59]

dpapad@chromium.org changed reviewers:
+ michaelpg@chromium.org

[dpapad, 2017-06-29 17:42:59]

Examples of currently existing Map usage,
https://cs.chromium.org/search/?q=chrome/browser/resources/+%22new+Set%22&typ....

Examples of currently existing Set usage,
https://cs.chromium.org/search/?q=chrome/browser/resources/+%22new+Set%22&typ....

Also according to https://kangax.github.io/compat-table/es6/#test-Map and
https://kangax.github.io/compat-table/es6/#test-Set there is full support even
on iOS 9 (with the exception of Set[Symbol.species] and Map[Symbol.species]
which is a very unlikely use case (see example at
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obje...).

[dpapad, 2017-06-29 17:43:10]

Description was changed from

==========
Move Map/Set to allowed features of ES6 styleguide.

Also remove backticks from markdown headers because they cause everything
between tha backticks to not render.

BUG=None
==========

to

==========
Move Map/Set to allowed features of ES6 styleguide.

Also remove backticks from markdown headers because they cause everything
between the backticks to not render.

BUG=None
==========

[dpapad, 2017-06-29 22:03:09]

Description was changed from

==========
Move Map/Set to allowed features of ES6 styleguide.

Also remove backticks from markdown headers because they cause everything
between the backticks to not render.

BUG=None
==========

to

==========
Move Map/Set to allowed features of ES6 styleguide.

Also remove backticks from markdown headers because they cause everything
between the backticks to not render in the TOC.

BUG=None
==========

[michaelpg, 2017-06-29 22:10:47]

lgtm

https://codereview.chromium.org/2965543002/diff/1/docs/es6_chromium.md
File docs/es6_chromium.md (right):

https://codereview.chromium.org/2965543002/diff/1/docs/es6_chromium.md#newcod...
docs/es6_chromium.md:239: var key = {};
While you're here, I'd suggest changing the example to use a more realistic key.
We don't want to be encouraging this use. (And it already says above that
objects can be used.)

[dpapad, 2017-06-29 22:16:51]

https://codereview.chromium.org/2965543002/diff/1/docs/es6_chromium.md
File docs/es6_chromium.md (right):

https://codereview.chromium.org/2965543002/diff/1/docs/es6_chromium.md#newcod...
docs/es6_chromium.md:239: var key = {};
On 2017/06/29 at 22:10:47, michaelpg wrote:
> While you're here, I'd suggest changing the example to use a more realistic
key. We don't want to be encouraging this use. (And it already says above that
objects can be used.)

Done.

[dpapad, 2017-06-29 22:16:55]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2017-06-29 22:16:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2965543002/#ps20001
(title: "Address comment.")

[commit-bot: I haz the power, 2017-06-29 22:17:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 23:10:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498774615010420,
"parent_rev": "8e88c30479190a74ad7599511e3b7dcffa74359c", "commit_rev":
"0f7c30871c4eb669bedfa348035bb5fb21c91746"}

[commit-bot: I haz the power, 2017-06-29 23:10:56]

Description was changed from

==========
Move Map/Set to allowed features of ES6 styleguide.

Also remove backticks from markdown headers because they cause everything
between the backticks to not render in the TOC.

BUG=None
==========

to

==========
Move Map/Set to allowed features of ES6 styleguide.

Also remove backticks from markdown headers because they cause everything
between the backticks to not render in the TOC.

BUG=None

Review-Url: https://codereview.chromium.org/2965543002
Cr-Commit-Position: refs/heads/master@{#483534}
Committed:
https://chromium.googlesource.com/chromium/src/+/0f7c30871c4eb669bedfa348035b...
==========

[commit-bot: I haz the power, 2017-06-29 23:10:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0f7c30871c4eb669bedfa348035b...