Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2965523002: Enable AreCrossProcessFramesPossible on Android (Closed)

Created:
3 years, 5 months ago by kenrb
Modified:
3 years, 5 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, jam, darin-cc_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable AreCrossProcessFramesPossible on Android Previous attempts to enable cross process frames on Android have caused changes in memory usage on Android Webview tests, resulting in them being reverted. This might be because the flag changed the behavior of --single-process, which is no longer the case since r485292 landed. The regressed benchmark was memory.top_10_mobile under Android Webview tests. We expect that the problem is now fixed and we can land this without causing regressions, but this is still a speculative attempt. BUG=690229, 737264 Review-Url: https://codereview.chromium.org/2965523002 Cr-Commit-Position: refs/heads/master@{#485361} Committed: https://chromium.googlesource.com/chromium/src/+/c3de9c1ad085f8a2210eb290b719468be08323c3

Patch Set 1 #

Patch Set 2 : For comparison purposes only #

Patch Set 3 : Original patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M content/common/site_isolation_policy.cc View 2 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
kenrb
creis@: PTAL?
3 years, 5 months ago (2017-07-10 19:42:26 UTC) #9
Charlie Reis
LGTM!
3 years, 5 months ago (2017-07-10 19:48:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2965523002/40001
3 years, 5 months ago (2017-07-10 20:08:41 UTC) #12
commit-bot: I haz the power
3 years, 5 months ago (2017-07-10 20:17:58 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c3de9c1ad085f8a2210eb290b719...

Powered by Google App Engine
This is Rietveld 408576698