Ash: Inline InitKeyboard, and make the caller of it call CreateKeyboard.

Ash: Inline InitKeyboard, and make the caller of it call CreateKeyboard.

InitKeyboard creates a keyboard controller but doesn't associate it with any
root window controller. It's potentially problematic if
keyboard::ShowKeyboard is called before RootWindowController::ActivateKeyboard.

Bug: 712873

Change-Id: I5b34cd6f8b9e1b0736b5d91880e3aedc9d57970c
Reviewed-on: https://chromium-review.googlesource.com/535221
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>;
Commit-Queue: Keigo Oka <oka@chromium.org>;
Cr-Original-Commit-Position: refs/heads/master@{#480313}
Review-Url: https://codereview.chromium.org/2965503003 .
Cr-Commit-Position: refs/branch-heads/3112@{#494}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
Committed: https://chromium.googlesource.com/chromium/src/+/0b1b723c301e612c809a502f028dfc0fbba6be21

[oka, 2017-06-29 19:19:52]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 19:20:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 19:20:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 19:20:09]

Dry run: CLs for remote refs other than refs/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[oka, 2017-06-29 20:29:07]

Description was changed from

==========
Ash: Inline InitKeyboard, and make the caller of it call CreateKeyboard.

InitKeyboard creates a keyboard controller but doesn't associate it with any
root window controller. It's potentially problematic if
keyboard::ShowKeyboard is called before RootWindowController::ActivateKeyboard.

Bug: 712873

Change-Id: I5b34cd6f8b9e1b0736b5d91880e3aedc9d57970c
Reviewed-on: https://chromium-review.googlesource.com/535221
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480313}
(cherry picked from commit e82281ac05b7c0571c8f3c603487f74b686547f9)
==========

to

==========
Ash: Inline InitKeyboard, and make the caller of it call CreateKeyboard.

InitKeyboard creates a keyboard controller but doesn't associate it with any
root window controller. It's potentially problematic if
keyboard::ShowKeyboard is called before RootWindowController::ActivateKeyboard.

Bug: 712873

NOTRY=true and NOPRESUBMIT=true

Change-Id: I5b34cd6f8b9e1b0736b5d91880e3aedc9d57970c
Reviewed-on: https://chromium-review.googlesource.com/535221
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480313}
(cherry picked from commit e82281ac05b7c0571c8f3c603487f74b686547f9)
==========

[oka, 2017-06-29 20:29:13]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[oka, 2017-06-29 20:29:24]

Description was changed from

==========
Ash: Inline InitKeyboard, and make the caller of it call CreateKeyboard.

InitKeyboard creates a keyboard controller but doesn't associate it with any
root window controller. It's potentially problematic if
keyboard::ShowKeyboard is called before RootWindowController::ActivateKeyboard.

Bug: 712873

NOTRY=true and NOPRESUBMIT=true

Change-Id: I5b34cd6f8b9e1b0736b5d91880e3aedc9d57970c
Reviewed-on: https://chromium-review.googlesource.com/535221
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480313}
(cherry picked from commit e82281ac05b7c0571c8f3c603487f74b686547f9)
==========

to

==========
Ash: Inline InitKeyboard, and make the caller of it call CreateKeyboard.

InitKeyboard creates a keyboard controller but doesn't associate it with any
root window controller. It's potentially problematic if
keyboard::ShowKeyboard is called before RootWindowController::ActivateKeyboard.

Bug: 712873

NOTRY=true
NOPRESUBMIT=true

Change-Id: I5b34cd6f8b9e1b0736b5d91880e3aedc9d57970c
Reviewed-on: https://chromium-review.googlesource.com/535221
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480313}
(cherry picked from commit e82281ac05b7c0571c8f3c603487f74b686547f9)
==========

[oka, 2017-06-29 20:29:39]

The CQ bit was unchecked by oka@chromium.org

[oka, 2017-06-29 20:29:40]

The CQ bit was checked by oka@chromium.org

[oka, 2017-06-29 20:29:40]

The CQ bit was unchecked by oka@chromium.org

[oka, 2017-06-29 20:29:47]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 20:30:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 20:30:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 20:30:41]

Dry run: This issue passed the CQ dry run.

[oka, 2017-06-29 20:56:46]

The CQ bit was checked by oka@chromium.org

[oka, 2017-06-29 20:56:52]

The CQ bit was unchecked by oka@chromium.org

[oka, 2017-06-29 20:57:32]

Description was changed from

==========
Ash: Inline InitKeyboard, and make the caller of it call CreateKeyboard.

InitKeyboard creates a keyboard controller but doesn't associate it with any
root window controller. It's potentially problematic if
keyboard::ShowKeyboard is called before RootWindowController::ActivateKeyboard.

Bug: 712873

NOTRY=true
NOPRESUBMIT=true

Change-Id: I5b34cd6f8b9e1b0736b5d91880e3aedc9d57970c
Reviewed-on: https://chromium-review.googlesource.com/535221
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480313}
(cherry picked from commit e82281ac05b7c0571c8f3c603487f74b686547f9)
==========

to

==========
Ash: Inline InitKeyboard, and make the caller of it call CreateKeyboard.

InitKeyboard creates a keyboard controller but doesn't associate it with any
root window controller. It's potentially problematic if
keyboard::ShowKeyboard is called before RootWindowController::ActivateKeyboard.

Bug: 712873

Change-Id: I5b34cd6f8b9e1b0736b5d91880e3aedc9d57970c
Reviewed-on: https://chromium-review.googlesource.com/535221
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480313}
(cherry picked from commit e82281ac05b7c0571c8f3c603487f74b686547f9)
==========

[oka, 2017-06-29 20:58:15]

The CQ bit was checked by oka@chromium.org

[commit-bot: I haz the power, 2017-06-29 20:58:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 20:58:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 20:58:43]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[oka, 2017-06-29 21:00:38]

Description was changed from

==========
Ash: Inline InitKeyboard, and make the caller of it call CreateKeyboard.

InitKeyboard creates a keyboard controller but doesn't associate it with any
root window controller. It's potentially problematic if
keyboard::ShowKeyboard is called before RootWindowController::ActivateKeyboard.

Bug: 712873

Change-Id: I5b34cd6f8b9e1b0736b5d91880e3aedc9d57970c
Reviewed-on: https://chromium-review.googlesource.com/535221
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480313}
(cherry picked from commit e82281ac05b7c0571c8f3c603487f74b686547f9)
==========

to

==========
Ash: Inline InitKeyboard, and make the caller of it call CreateKeyboard.

InitKeyboard creates a keyboard controller but doesn't associate it with any
root window controller. It's potentially problematic if
keyboard::ShowKeyboard is called before RootWindowController::ActivateKeyboard.

Bug: 712873

Change-Id: I5b34cd6f8b9e1b0736b5d91880e3aedc9d57970c
Reviewed-on: https://chromium-review.googlesource.com/535221
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Keigo Oka <oka@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#480313}
Review-Url: https://codereview.chromium.org/2965503003 .
Cr-Commit-Position: refs/branch-heads/3112@{#494}
Cr-Branched-From:
b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
Committed:
https://chromium.googlesource.com/chromium/src/+/0b1b723c301e612c809a502f028d...
==========

[oka, 2017-06-29 21:00:40]

Committed patchset #2 (id:20001) manually as
0b1b723c301e612c809a502f028dfc0fbba6be21.