Import Axe Core Accessibility Testing Library

Import Axe Core Accessibility Testing Library

BUG=737739
Review-Url: https://codereview.chromium.org/2965493003
Cr-Commit-Position: refs/heads/master@{#485078}
Committed: https://chromium.googlesource.com/chromium/src/+/2d9116a4ec5232fe2395ddbc4ca01de8b1cef6de

[hcarmona, 2017-06-30 00:45:17]

Description was changed from

==========
Import Axe Core Accessibility Testing Library

R=aboxhall@chromium.org,quacht@google.com
BUG=737739
==========

to

==========
Import Axe Core Accessibility Testing Library

BUG=737739
==========

[hcarmona, 2017-06-30 00:48:13]

PTAL, this is built from the shadowDOM branch, we can update this after it's
moved to the main branch

[aboxhall, 2017-06-30 06:19:40]

On 2017/06/30 00:48:13, hcarmona wrote:
> PTAL, this is built from the shadowDOM branch, we can update this after it's
> moved to the main branch

I'd suggest going the other direction - work off the main branch to get the
integration, and then update once Shadow DOM is merged to the main branch.

[aboxhall, 2017-06-30 06:21:13]

On 2017/06/30 06:19:40, aboxhall wrote:
> On 2017/06/30 00:48:13, hcarmona wrote:
> > PTAL, this is built from the shadowDOM branch, we can update this after it's
> > moved to the main branch
> 
> I'd suggest going the other direction - work off the main branch to get the
> integration, and then update once Shadow DOM is merged to the main branch.

Hm, that said, I see why you want to do it this way - you'll get test failures
sooner. Makes sense :)

[aboxhall, 2017-06-30 06:48:37]

lgtm

[quacht, 2017-06-30 17:18:22]

On 2017/06/30 06:48:37, aboxhall wrote:
> lgtm

I joined axe-core's slack channel and dylanb, one of the people working actively
on the shadow DOM branch said we "might want to start integration with the
released axe-core until the shadowDOM branch settles a bit." We'll need to
update this library at a later point as more changes on the branch are made.

Still, lgtm

[hcarmona, 2017-06-30 17:54:57]

IIUC, it doesn't matter too much whether we pick the shadowDOM or released
branch to make our library right now because we'll need to update later when the
released branch has support for shadowDOM.

It's best to move forward with this change so we can integrate it into our tests
and get a11y errors faster.

[hcarmona, 2017-06-30 17:58:34]

hcarmona@chromium.org changed reviewers:
+ jam@chromium.org

[hcarmona, 2017-06-30 17:58:35]

We're adding this a11y testing library to chromium b/c it has more coverage than
accessibility developer tools. We are in the process of updating our tests to
support shadow dom and polymer.

jam@, would you be the right person to review this CL?

Thanks!

[jam, 2017-07-07 21:49:13]

lgtm

[hcarmona, 2017-07-07 22:19:53]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2017-07-07 22:20:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 22:46:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1499465993158310, "parent_rev":
"d43ca17f375b2f0cefc8ccaffa22e0c72ea6c040", "commit_rev":
"ac08685d248e296d3f95daff776678d1e0afbe9b"}

[commit-bot: I haz the power, 2017-07-07 22:47:08]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1499465993158310, "parent_rev":
"f84f0baa01bc5b6f41ea428f1a465a05763c4ea1", "commit_rev":
"2d9116a4ec5232fe2395ddbc4ca01de8b1cef6de"}

[commit-bot: I haz the power, 2017-07-07 22:47:36]

Description was changed from

==========
Import Axe Core Accessibility Testing Library

BUG=737739
==========

to

==========
Import Axe Core Accessibility Testing Library

BUG=737739

Review-Url: https://codereview.chromium.org/2965493003
Cr-Commit-Position: refs/heads/master@{#485078}
Committed:
https://chromium.googlesource.com/chromium/src/+/2d9116a4ec5232fe2395ddbc4ca0...
==========

[commit-bot: I haz the power, 2017-07-07 22:47:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2d9116a4ec5232fe2395ddbc4ca0...