Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2965353002: Revert of Port NotificationViewMD unit tests from NotificationViewTest. (Closed)

Created:
3 years, 5 months ago by mastiz
Modified:
3 years, 5 months ago
Reviewers:
yoshiki, tetsui, fukino
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Port NotificationViewMD unit tests from NotificationViewTest. (patchset #5 id:80001 of https://codereview.chromium.org/2966343002/ ) Reason for revert: message_center_unittests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1) BUG=739356 Original issue's description: > Port NotificationViewMD unit tests from NotificationViewTest. > > Ported unit tests from NotificationViewTest and created > NotificationViewMDTest. Also fixed bugs and check failures found during > porting the tests. > * Fix RemoveChildView null checking. (CHECK fails on debug builds.) > * Fix action button hover state inheritance. > > Following tests are not ported from NotificationViewTest, mostly > because the feature is unimplemented or the test is not applicable. > * CreateOrUpdateTestSettingsButton > * TestLineLimits > * TestImageSizing > * SettingsButtonTest > * ViewOrderingTest > * FormatContextMessageTest > > BUG=733948 > TEST=out/Debug/message_center_unittests > > Review-Url: https://codereview.chromium.org/2966343002 > Cr-Commit-Position: refs/heads/master@{#484851} > Committed: https://chromium.googlesource.com/chromium/src/+/9a4a1121fae26a1727728888a41975bc15e3e62f TBR=fukino@chromium.org,yoshiki@chromium.org,tetsui@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=733948 Review-Url: https://codereview.chromium.org/2965353002 Cr-Commit-Position: refs/heads/master@{#484899} Committed: https://chromium.googlesource.com/chromium/src/+/a0e04c835cae01af85b8532022cec6ee5346f69f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -547 lines) Patch
M ui/message_center/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/message_center/views/notification_view_md.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/message_center/views/notification_view_md.cc View 12 chunks +11 lines, -38 lines 0 comments Download
D ui/message_center/views/notification_view_md_unittest.cc View 1 chunk +0 lines, -501 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
mastiz
Created Revert of Port NotificationViewMD unit tests from NotificationViewTest.
3 years, 5 months ago (2017-07-07 12:45:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2965353002/1
3 years, 5 months ago (2017-07-07 12:45:26 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-07 12:45:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a0e04c835cae01af85b8532022ce...

Powered by Google App Engine
This is Rietveld 408576698