Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2965333002: Avoid PermissionDescriptor name collision. (Closed)

Created:
3 years, 5 months ago by Daniel Bratell
Modified:
3 years, 5 months ago
CC:
shalamov, blink-reviews, chromium-reviews, haraken, hongchan, mfoltz+watch_chromium.org, Mikhail, mlamouri+watch-blink_chromium.org, Raymond Toy, timvolodine, wanming.lin
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid PermissionDescriptor name collision. Fix to allow us to skip a permissions exclusion for jumbo. Locally rename one of them to MojoPermissionDescriptor. Review-Url: https://codereview.chromium.org/2965333002 Cr-Commit-Position: refs/heads/master@{#484953} Committed: https://chromium.googlesource.com/chromium/src/+/e6c9db4e3fbe62db84c25f041e3f8a29a12b2dd7

Patch Set 1 #

Patch Set 2 : Dropping code to test compile in jumbo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/permissions/PermissionUtils.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Daniel Bratell
mlamouri, please take a look at this patch? It's to avoid having to special case ...
3 years, 5 months ago (2017-07-07 13:39:13 UTC) #8
mlamouri (slow - plz ping)
lgtm
3 years, 5 months ago (2017-07-07 14:28:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2965333002/20001
3 years, 5 months ago (2017-07-07 14:32:46 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-07-07 16:38:52 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e6c9db4e3fbe62db84c25f041e3f...

Powered by Google App Engine
This is Rietveld 408576698