Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2965263002: Make exception reporting best effort. (Closed)

Created:
3 years, 5 months ago by devoncarew
Modified:
3 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
devoncarew
We now catch and ignore any errors that occur when attempting to report an exception.
3 years, 5 months ago (2017-07-06 18:37:54 UTC) #2
Brian Wilkerson
lgtm
3 years, 5 months ago (2017-07-06 18:40:41 UTC) #3
devoncarew
3 years, 5 months ago (2017-07-06 20:35:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a2e95192795775969be0bdd03926ead320ba144e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698