Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: pkg/analyzer_cli/lib/src/driver.dart

Issue 2965263002: Make exception reporting best effort. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/analysis_server.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_cli/lib/src/driver.dart
diff --git a/pkg/analyzer_cli/lib/src/driver.dart b/pkg/analyzer_cli/lib/src/driver.dart
index 22fec9e634c5a9a13251cbd5c71886b9d6267d89..680b6b3af76ccf6309159b05140be4ce5dea5ff6 100644
--- a/pkg/analyzer_cli/lib/src/driver.dart
+++ b/pkg/analyzer_cli/lib/src/driver.dart
@@ -225,7 +225,9 @@ class Driver implements CommandLineStarter {
try {
return await _analyzeAllImpl(options);
} catch (e, st) {
- crashReportSender.sendReport(e, stackTrace: st);
+ // Catch and ignore any exceptions when reporting exceptions (network
+ // errors or other).
+ crashReportSender.sendReport(e, stackTrace: st).catchError((_) {});
rethrow;
} finally {
previous.makeCurrent();
« no previous file with comments | « pkg/analysis_server/lib/src/analysis_server.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698