Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2965223002: Change inference element invariants (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change inference element invariants - members must be declarations - parameters must be implementations R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/29df2fbb4f9492b197a675e6c7baca32f230d806

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : More entities #

Total comments: 4

Patch Set 4 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -111 lines) Patch
M pkg/compiler/lib/src/common_elements.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/builder.dart View 1 2 10 chunks +18 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/closure_tracer.dart View 1 2 6 chunks +11 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_engine.dart View 1 2 9 chunks +33 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/list_tracer.dart View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/locals_handler.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/map_tracer.dart View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 1 2 20 chunks +53 lines, -32 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_system.dart View 3 chunks +8 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 2 3 9 chunks +15 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-07-06 13:23:17 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2965223002/diff/40001/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (right): https://codereview.chromium.org/2965223002/diff/40001/pkg/compiler/lib/src/ssa/builder.dart#newcode242 pkg/compiler/lib/src/ssa/builder.dart:242: elementInferenceResults = _resultOf(resolvedAst.element); any reason to prefer this ...
3 years, 5 months ago (2017-07-06 18:00:59 UTC) #3
Johnni Winther
Committed patchset #4 (id:60001) manually as 29df2fbb4f9492b197a675e6c7baca32f230d806 (presubmit successful).
3 years, 5 months ago (2017-07-07 07:22:19 UTC) #5
Johnni Winther
3 years, 5 months ago (2017-07-07 09:58:41 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2965223002/diff/40001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/2965223002/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:242: elementInferenceResults =
_resultOf(resolvedAst.element);
On 2017/07/06 18:00:59, Siggi Cherem (dart-lang) wrote:
> any reason to prefer this over `target.declaration`?
> 
> To me using `target.declaration` communicates more clearly what's the
invariant
> you are going for.

Done.

https://codereview.chromium.org/2965223002/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:245:
sourceElementStack.add(resolvedAst.element);
On 2017/07/06 18:00:59, Siggi Cherem (dart-lang) wrote:
> funny - this looks like this was a bug (seeing that sourceElementStack was
> supposed to contain the declaration nodes)

Acknowledged.

Powered by Google App Engine
This is Rietveld 408576698