Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Side by Side Diff: pkg/compiler/lib/src/inferrer/list_tracer.dart

Issue 2965223002: Change inference element invariants (Closed)
Patch Set: Updated cf. comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library compiler.src.inferrer.list_tracer; 5 library compiler.src.inferrer.list_tracer;
6 6
7 import '../elements/elements.dart'; 7 import '../elements/entities.dart';
8 import '../js_backend/backend.dart' show JavaScriptBackend; 8 import '../js_backend/backend.dart' show JavaScriptBackend;
9 import '../universe/selector.dart' show Selector; 9 import '../universe/selector.dart' show Selector;
10 import '../util/util.dart' show Setlet; 10 import '../util/util.dart' show Setlet;
11 import 'node_tracer.dart'; 11 import 'node_tracer.dart';
12 import 'type_graph_nodes.dart'; 12 import 'type_graph_nodes.dart';
13 13
14 /** 14 /**
15 * A set of selector names that [List] implements, that we know do not 15 * A set of selector names that [List] implements, that we know do not
16 * change the element type of the list, or let the list escape to code 16 * change the element type of the list, or let the list escape to code
17 * that might change the element type. 17 * that might change the element type.
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 return false; 157 return false;
158 } 158 }
159 } 159 }
160 160
161 visitClosureCallSiteTypeInformation(ClosureCallSiteTypeInformation info) { 161 visitClosureCallSiteTypeInformation(ClosureCallSiteTypeInformation info) {
162 bailout('Passed to a closure'); 162 bailout('Passed to a closure');
163 } 163 }
164 164
165 visitStaticCallSiteTypeInformation(StaticCallSiteTypeInformation info) { 165 visitStaticCallSiteTypeInformation(StaticCallSiteTypeInformation info) {
166 super.visitStaticCallSiteTypeInformation(info); 166 super.visitStaticCallSiteTypeInformation(info);
167 Element called = info.calledElement; 167 MemberEntity called = info.calledElement;
168 if (compiler.backend 168 if (inferrer.closedWorld.commonElements.isForeign(called) &&
169 .isForeign(inferrer.closedWorld.commonElements, called) &&
170 called.name == JavaScriptBackend.JS) { 169 called.name == JavaScriptBackend.JS) {
171 bailout('Used in JS ${info.call}'); 170 bailout('Used in JS ${info.call}');
172 } 171 }
173 } 172 }
174 173
175 visitDynamicCallSiteTypeInformation(DynamicCallSiteTypeInformation info) { 174 visitDynamicCallSiteTypeInformation(DynamicCallSiteTypeInformation info) {
176 super.visitDynamicCallSiteTypeInformation(info); 175 super.visitDynamicCallSiteTypeInformation(info);
177 Selector selector = info.selector; 176 Selector selector = info.selector;
178 String selectorName = selector.name; 177 String selectorName = selector.name;
179 if (currentUser == info.receiver) { 178 if (currentUser == info.receiver) {
(...skipping 26 matching lines...) Expand all
206 callsGrowableMethod = true; 205 callsGrowableMethod = true;
207 assignments.add(inferrer.types.nullType); 206 assignments.add(inferrer.types.nullType);
208 } 207 }
209 } else if (selector.isCall && 208 } else if (selector.isCall &&
210 !info.targets.every((element) => element.isFunction)) { 209 !info.targets.every((element) => element.isFunction)) {
211 bailout('Passed to a closure'); 210 bailout('Passed to a closure');
212 return; 211 return;
213 } 212 }
214 } 213 }
215 } 214 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/inferrer/inferrer_engine.dart ('k') | pkg/compiler/lib/src/inferrer/locals_handler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698