Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: components/omnibox/browser/zero_suggest_provider.h

Issue 2965173002: Add ContextualSuggestionsService to Omnibox (Closed)
Patch Set: Move contextual suggestions service to c/o/b Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/zero_suggest_provider.h
diff --git a/components/omnibox/browser/zero_suggest_provider.h b/components/omnibox/browser/zero_suggest_provider.h
index ca1e0a6256f91603c9bd51837148c16c5c1395d6..71bf84e6962534c9c16b1b56ed3bb865c1f8e7ec 100644
--- a/components/omnibox/browser/zero_suggest_provider.h
+++ b/components/omnibox/browser/zero_suggest_provider.h
@@ -98,9 +98,6 @@ class ZeroSuggestProvider : public BaseSearchProvider,
AutocompleteMatch NavigationToMatch(
const SearchSuggestionParser::NavigationResult& navigation);
- // Fetches zero-suggest suggestions by sending a request using |suggest_url|.
- void Run(const GURL& suggest_url);
-
// Converts the parsed results to a set of AutocompleteMatches and adds them
// to |matches_|. Also update the histograms for how many results were
// received.
@@ -116,6 +113,9 @@ class ZeroSuggestProvider : public BaseSearchProvider,
// function to return those |urls|.
void OnMostVisitedUrlsAvailable(const history::MostVisitedURLList& urls);
+ void OnContextualSuggestionsFetcherAvailable(
Mark P 2017/07/18 19:11:30 Please comment.
+ std::unique_ptr<net::URLFetcher> fetcher);
+
// Whether we can show zero suggest suggestions that are not based on
// |current_page_url|. Also checks that other conditions for non-contextual
// zero suggest are satisfied.

Powered by Google App Engine
This is Rietveld 408576698