Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: components/omnibox/browser/omnibox_field_trial.cc

Issue 2965173002: Add ContextualSuggestionsService to Omnibox (Closed)
Patch Set: Move contextual suggestions service to c/o/b Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/omnibox_field_trial.cc
diff --git a/components/omnibox/browser/omnibox_field_trial.cc b/components/omnibox/browser/omnibox_field_trial.cc
index 6357182923211fa3d33cc51ef56ee78121111b84..be5837460d1e059cf7594c15367580b6ae4600ec 100644
--- a/components/omnibox/browser/omnibox_field_trial.cc
+++ b/components/omnibox/browser/omnibox_field_trial.cc
@@ -85,7 +85,7 @@ const base::Feature kSearchProviderContextAllowHttpsUrls{
"OmniboixSearchProviderContextAllowHttpsUrls",
base::FEATURE_DISABLED_BY_DEFAULT};
-// Feature used for the Zero Suggest Redirect to Chrome Field Trial.
+// Feature used for the Zero Suggest Redirect to Chrome Field Trial
Mark P 2017/07/18 19:11:29 nit: please restore the period. :-)
const base::Feature kZeroSuggestRedirectToChrome{
"ZeroSuggestRedirectToChrome", base::FEATURE_DISABLED_BY_DEFAULT};
@@ -700,25 +700,6 @@ int OmniboxFieldTrial::GetPhysicalWebAfterTypingBaseRelevance() {
return 700;
}
-// static
-bool OmniboxFieldTrial::InZeroSuggestRedirectToChromeFieldTrial() {
- return base::FeatureList::IsEnabled(omnibox::kZeroSuggestRedirectToChrome);
-}
-
-// static
-std::string OmniboxFieldTrial::ZeroSuggestRedirectToChromeServerAddress() {
- return base::GetFieldTrialParamValueByFeature(
- omnibox::kZeroSuggestRedirectToChrome,
- kZeroSuggestRedirectToChromeServerAddressParam);
-}
-
-// static
-std::string OmniboxFieldTrial::ZeroSuggestRedirectToChromeAdditionalFields() {
- return base::GetFieldTrialParamValueByFeature(
- omnibox::kZeroSuggestRedirectToChrome,
- kZeroSuggestRedirectToChromeAdditionalFieldsParam);
-}
-
const char OmniboxFieldTrial::kBundledExperimentFieldTrialName[] =
"OmniboxBundledExperimentV1";
const char OmniboxFieldTrial::kDisableProvidersRule[] = "DisableProviders";
@@ -802,12 +783,6 @@ const char OmniboxFieldTrial::kPhysicalWebZeroSuggestBaseRelevanceParam[] =
const char OmniboxFieldTrial::kPhysicalWebAfterTypingBaseRelevanceParam[] =
"PhysicalWebAfterTypingBaseRelevanceParam";
-const char OmniboxFieldTrial::kZeroSuggestRedirectToChromeServerAddressParam[] =
- "ZeroSuggestRedirectToChromeServerAddress";
-const char
- OmniboxFieldTrial::kZeroSuggestRedirectToChromeAdditionalFieldsParam[] =
- "ZeroSuggestRedirectToChromeAdditionalFields";
-
const char OmniboxFieldTrial::kUIMaxAutocompleteMatchesParam[] =
"UIMaxAutocompleteMatches";
const char OmniboxFieldTrial::kUIVerticalMarginParam[] = "UIVerticalMargin";

Powered by Google App Engine
This is Rietveld 408576698