Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2965163002: [Night Light] Accessibility: Make ChromeVox speak button status on toggles (Closed)

Created:
3 years, 5 months ago by afakhry
Modified:
3 years, 5 months ago
Reviewers:
tdanderson, dmazzoni
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Night Light] Accessibility: Make ChromeVox speak button status on toggles Make ChromeVox speak the status of the Night Light system tray button when the button is pressed and the status is toggled. BUG=706067 Review-Url: https://codereview.chromium.org/2965163002 Cr-Commit-Position: refs/heads/master@{#484948} Committed: https://chromium.googlesource.com/chromium/src/+/55e112b5a53ab48350bc1fae5e7dc60f525e7d0d

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M ash/system/night_light/night_light_toggle_button.h View 1 chunk +4 lines, -1 line 0 comments Download
M ash/system/night_light/night_light_toggle_button.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M ash/system/tiles/tiles_default_view.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
afakhry
dmazzoni@ Could you please take a look? Thank you.
3 years, 5 months ago (2017-07-06 00:47:22 UTC) #4
afakhry
+tdanderson@ for OWNERS too. Thanks!
3 years, 5 months ago (2017-07-06 21:07:45 UTC) #12
dmazzoni
lgtm
3 years, 5 months ago (2017-07-06 23:09:03 UTC) #13
tdanderson
LGTM
3 years, 5 months ago (2017-07-07 15:48:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2965163002/20001
3 years, 5 months ago (2017-07-07 16:19:42 UTC) #16
commit-bot: I haz the power
3 years, 5 months ago (2017-07-07 16:25:39 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/55e112b5a53ab48350bc1fae5e7d...

Powered by Google App Engine
This is Rietveld 408576698