Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 2965133002: DevTools: fix incorrect device preset resolution (Closed)

Created:
3 years, 5 months ago by luoe
Modified:
3 years, 5 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix incorrect device preset resolution BUG=737919 Review-Url: https://codereview.chromium.org/2965133002 Cr-Commit-Position: refs/heads/master@{#484421} Committed: https://chromium.googlesource.com/chromium/src/+/e97871b5c8dac1a414318d7a6554ba033894cc36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
luoe
Please take a look
3 years, 5 months ago (2017-07-05 21:34:49 UTC) #2
luoe
Please take a look Here's some sources that corroborate these changed numbers: http://dpi.lv/ https://mydevice.io/devices/ https://en.wikipedia.org/wiki/Fire_HDX ...
3 years, 5 months ago (2017-07-05 21:35:35 UTC) #3
lushnikov
lgtm
3 years, 5 months ago (2017-07-05 22:12:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2965133002/1
3 years, 5 months ago (2017-07-05 22:44:16 UTC) #6
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 00:35:16 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e97871b5c8dac1a414318d7a6554...

Powered by Google App Engine
This is Rietveld 408576698