Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: net/tools/dump_cache/dump_cache.cc

Issue 296513013: Cleanup: Use base::CommandLine in net/ (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/tools/dump_cache/dump_cache.cc
===================================================================
--- net/tools/dump_cache/dump_cache.cc (revision 272153)
+++ net/tools/dump_cache/dump_cache.cc (working copy)
@@ -96,7 +96,7 @@
if (!base::LaunchProcess(command_line, base::LaunchOptions(), NULL)) {
printf("Unable to launch the needed version of this tool: %ls\n",
command_line.GetProgram().value().c_str());
- printf(kUpgradeHelp);
+ printf("%s", kUpgradeHelp);
Ryan Sleevi 2014/05/22 21:54:40 lulz. Subtle.
Lei Zhang 2014/05/22 22:19:26 cpplint actually catches this stuff.
return TOOL_NOT_FOUND;
}
return ALL_GOOD;
@@ -110,9 +110,10 @@
// Setup an AtExitManager so Singleton objects will be destroyed.
base::AtExitManager at_exit_manager;
- CommandLine::Init(argc, argv);
+ base::CommandLine::Init(argc, argv);
- const CommandLine& command_line = *CommandLine::ForCurrentProcess();
+ const base::CommandLine& command_line =
+ *base::CommandLine::ForCurrentProcess();
base::FilePath input_path = command_line.GetSwitchValuePath(kInputPath);
if (input_path.empty())
return Help();

Powered by Google App Engine
This is Rietveld 408576698