Cleanup: Use base::CommandLine in net/

net/tools/dump_cache/dump_cache.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This command-line program dumps the contents of a set of cache files, either
 // to stdout or to another set of cache files.
 
 #include <stdio.h>
 #include <string>
 
@@ skipping 78 matching lines @@
     command_line.SetProgram(program);
   }
 
   if (do_upgrade || do_convert_to_text)
     command_line.AppendSwitch(kSlave);
 
   command_line.AppendSwitchNative(kPipe, pipe_number);
   if (!base::LaunchProcess(command_line, base::LaunchOptions(), NULL)) {
     printf("Unable to launch the needed version of this tool: %ls\n",
            command_line.GetProgram().value().c_str());
-    printf(kUpgradeHelp);
+    printf("%s", kUpgradeHelp);

[Ryan Sleevi, 2014/05/22 21:54:40]

lulz. Subtle.

[Lei Zhang, 2014/05/22 22:19:26]

cpplint actually catches this stuff.

     return TOOL_NOT_FOUND;
   }
   return ALL_GOOD;
 }
 
 #endif
 
 // -----------------------------------------------------------------------
 
 int main(int argc, const char* argv[]) {
   // Setup an AtExitManager so Singleton objects will be destroyed.
   base::AtExitManager at_exit_manager;
 
-  CommandLine::Init(argc, argv);
+  base::CommandLine::Init(argc, argv);
 
-  const CommandLine& command_line = *CommandLine::ForCurrentProcess();
+  const base::CommandLine& command_line =
+      *base::CommandLine::ForCurrentProcess();
   base::FilePath input_path = command_line.GetSwitchValuePath(kInputPath);
   if (input_path.empty())
     return Help();
 
   bool dump_to_files = command_line.HasSwitch(kDumpToFiles);
   bool upgrade = command_line.HasSwitch(kUpgrade);
 
   base::FilePath output_path = command_line.GetSwitchValuePath(kOutputPath);
   if ((dump_to_files || upgrade) && output_path.empty())
     return Help();
@@ skipping 52 matching lines @@
   }
 
   if (command_line.HasSwitch(kDumpContents))
     return DumpContents(input_path);
 
   if (command_line.HasSwitch(kDumpHeaders))
     return DumpHeaders(input_path);
 
   return Help();
 }