Cleanup: Use base::CommandLine in net/

Cleanup: Use base::CommandLine in net/

R=rsleevi@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274378

[Ryan Sleevi, 2014-05-22 21:52:48]

Bug #?

[Ryan Sleevi, 2014-05-22 21:54:40]

lgtm

https://codereview.chromium.org/296513013/diff/1/net/tools/dump_cache/dump_ca...
File net/tools/dump_cache/dump_cache.cc (right):

https://codereview.chromium.org/296513013/diff/1/net/tools/dump_cache/dump_ca...
net/tools/dump_cache/dump_cache.cc:99: printf("%s", kUpgradeHelp);
lulz. Subtle.

https://codereview.chromium.org/296513013/diff/1/net/tools/net_watcher/net_wa...
File net/tools/net_watcher/net_watcher.cc (right):

https://codereview.chromium.org/296513013/diff/1/net/tools/net_watcher/net_wa...
net/tools/net_watcher/net_watcher.cc:24: #if defined(USE_GLIB)
Unrelated?

[Lei Zhang, 2014-05-22 22:19:22]

On 2014/05/22 21:52:48, Ryan Sleevi wrote:
> Bug #?

No bug, so just general cleanup.

[Lei Zhang, 2014-05-22 22:19:26]

https://codereview.chromium.org/296513013/diff/1/net/tools/dump_cache/dump_ca...
File net/tools/dump_cache/dump_cache.cc (right):

https://codereview.chromium.org/296513013/diff/1/net/tools/dump_cache/dump_ca...
net/tools/dump_cache/dump_cache.cc:99: printf("%s", kUpgradeHelp);
On 2014/05/22 21:54:40, Ryan Sleevi wrote:
> lulz. Subtle.

cpplint actually catches this stuff.

https://codereview.chromium.org/296513013/diff/1/net/tools/net_watcher/net_wa...
File net/tools/net_watcher/net_watcher.cc (right):

https://codereview.chromium.org/296513013/diff/1/net/tools/net_watcher/net_wa...
net/tools/net_watcher/net_watcher.cc:24: #if defined(USE_GLIB)
On 2014/05/22 21:54:40, Ryan Sleevi wrote:
> Unrelated?

Yes, but might as well.

[Lei Zhang, 2014-05-22 22:19:36]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-05-22 22:22:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/296513013/1

[commit-bot: I haz the power, 2014-05-22 23:28:46]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/8333)

[commit-bot: I haz the power, 2014-05-22 23:33:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 23:33:18]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[Lei Zhang, 2014-05-24 07:23:59]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-05-24 07:24:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/296513013/20001

[commit-bot: I haz the power, 2014-05-24 11:18:52]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-24 11:23:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-24 11:23:14]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Ryan Sleevi, 2014-06-02 23:20:39]

Ping: Manual landing required?

[Lei Zhang, 2014-06-02 23:22:21]

On 2014/06/02 23:20:39, Ryan Sleevi wrote:
> Ping: Manual landing required?

Ya, I've been trying about one a day, but the tree's often red. Maybe now...

[Lei Zhang, 2014-06-03 00:01:09]

Committed patchset #2 manually as r274378.