Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2965073002: [Payment Request] Moves PaymentRequest into the payments namespace (Closed)

Created:
3 years, 5 months ago by Moe
Modified:
3 years, 5 months ago
Reviewers:
jif
CC:
chromium-reviews, gogerald+paymentswatch_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, mahmadi+paymentsioswatch_chromium.org, mahmadi+paymentswatch_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payment Request] Moves PaymentRequest into the payments namespace This fixes the 'lldb reference to PaymentRequest is ambiguous' problem BUG=602666 ' Review-Url: https://codereview.chromium.org/2965073002 Cr-Commit-Position: refs/heads/master@{#484458} Committed: https://chromium.googlesource.com/chromium/src/+/cfe26b9f7e85e11d1eafe09d78ba0b2e201eea57

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -175 lines) Patch
M ios/chrome/browser/payments/payment_request.h View 1 8 chunks +20 lines, -18 lines 0 comments Download
M ios/chrome/browser/payments/payment_request.mm View 1 10 chunks +24 lines, -22 lines 0 comments Download
M ios/chrome/browser/payments/payment_request_unittest.mm View 1 20 chunks +36 lines, -32 lines 0 comments Download
M ios/chrome/browser/payments/payment_request_util.h View 1 3 chunks +4 lines, -5 lines 0 comments Download
M ios/chrome/browser/payments/payment_request_util.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/payments/test_payment_request.h View 1 4 chunks +7 lines, -4 lines 0 comments Download
M ios/chrome/browser/payments/test_payment_request.mm View 1 2 chunks +5 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/payments/address_edit_coordinator.h View 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/payments/address_edit_coordinator_unittest.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/address_edit_mediator.h View 2 chunks +5 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/address_edit_mediator.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/billing_address_selection_coordinator.h View 2 chunks +5 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/payments/billing_address_selection_coordinator_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/billing_address_selection_mediator.h View 2 chunks +5 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/payments/billing_address_selection_mediator.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/billing_address_selection_mediator_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/contact_info_edit_coordinator.h View 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/payments/contact_info_edit_coordinator_unittest.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/contact_info_edit_mediator.h View 2 chunks +5 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/contact_info_edit_mediator.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/contact_info_edit_mediator_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/contact_info_selection_coordinator.h View 2 chunks +5 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/payments/contact_info_selection_coordinator_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/contact_info_selection_mediator.h View 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/payments/contact_info_selection_mediator.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/contact_info_selection_mediator_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/credit_card_edit_coordinator.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/payments/credit_card_edit_coordinator.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/payments/credit_card_edit_coordinator_unittest.mm View 1 1 chunk +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/credit_card_edit_mediator.h View 3 chunks +5 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/credit_card_edit_mediator.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_items_display_coordinator.h View 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/payments/payment_items_display_coordinator_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_items_display_mediator.h View 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/payments/payment_items_display_mediator.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_items_display_view_controller_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_method_selection_coordinator.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_method_selection_coordinator_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_method_selection_mediator.h View 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/payments/payment_method_selection_mediator.mm View 1 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_coordinator.h View 1 3 chunks +5 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_coordinator_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_manager.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_mediator.h View 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_mediator.mm View 1 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_mediator_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_view_controller_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/shipping_address_selection_coordinator.h View 2 chunks +5 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/payments/shipping_address_selection_coordinator_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/shipping_address_selection_mediator.h View 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/payments/shipping_address_selection_mediator.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/shipping_option_selection_coordinator.h View 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/payments/shipping_option_selection_coordinator_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/shipping_option_selection_mediator.h View 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/payments/shipping_option_selection_mediator.mm View 2 chunks +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
Moe
Hi JIF, Please take a look at this CL.
3 years, 5 months ago (2017-07-05 18:09:38 UTC) #2
jif
lgtm
3 years, 5 months ago (2017-07-05 18:16:08 UTC) #3
Moe
On 2017/07/05 at 18:16:08, jif wrote: > lgtm Thank you!
3 years, 5 months ago (2017-07-05 18:30:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2965073002/20001
3 years, 5 months ago (2017-07-06 03:24:24 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 03:40:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cfe26b9f7e85e11d1eafe09d78ba...

Powered by Google App Engine
This is Rietveld 408576698