Create third-party conflicts module whitelist/blacklist protobuf definitions.

Create third-party conflicts module whitelist/blacklist protobuf definitions.

This defines the format in which whitelist/blacklist information will be distributed.

BUG=690166
Review-Url: https://codereview.chromium.org/2965063003
Cr-Commit-Position: refs/heads/master@{#486396}
Committed: https://chromium.googlesource.com/chromium/src/+/c0ce31467ec5d9f79c3e1e069f785d211a03d655

[chrisha, 2017-07-06 19:12:32]

chrisha@chromium.org changed reviewers:
+ pmonette@chromium.org

[chrisha, 2017-07-06 19:12:33]

pmonette, PTAL for the proto file?

[Patrick Monette, 2017-07-06 20:05:54]

lgtm

https://codereview.chromium.org/2965063003/diff/20001/chrome/browser/conflict...
File chrome/browser/conflicts/proto/module_list.proto (right):

https://codereview.chromium.org/2965063003/diff/20001/chrome/browser/conflict...
chrome/browser/conflicts/proto/module_list.proto:5: syntax = "proto2";
Nit: Space between syntax and option, from what I can tell from the majority of
proto files in Chrome.

https://codereview.chromium.org/2965063003/diff/20001/chrome/browser/conflict...
chrome/browser/conflicts/proto/module_list.proto:47: // to the OU specified in
the signature.
What's OU?

https://codereview.chromium.org/2965063003/diff/20001/chrome/browser/conflict...
chrome/browser/conflicts/proto/module_list.proto:70: // message will only be
displayed if a mathing software entry with
s/mathing/matching

[chrisha, 2017-07-11 19:31:01]

The CQ bit was checked by chrisha@chromium.org

[chrisha, 2017-07-11 19:31:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
pmonette@chromium.org
Link to the patchset: https://codereview.chromium.org/2965063003/#ps40001
(title: "Address nits.")

[commit-bot: I haz the power, 2017-07-11 19:31:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-11 23:03:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-11 23:03:55]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[chrisha, 2017-07-13 14:35:12]

The CQ bit was checked by chrisha@chromium.org

[commit-bot: I haz the power, 2017-07-13 14:35:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-13 15:57:35]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499956512350990,
"parent_rev": "20b96a644701efd68340e1951f974b50275df295", "commit_rev":
"c0ce31467ec5d9f79c3e1e069f785d211a03d655"}

[commit-bot: I haz the power, 2017-07-13 15:57:51]

Description was changed from

==========
Create third-party conflicts module whitelist/blacklist protobuf definitions.

This defines the format in which whitelist/blacklist information will be
distributed.

BUG=690166
==========

to

==========
Create third-party conflicts module whitelist/blacklist protobuf definitions.

This defines the format in which whitelist/blacklist information will be
distributed.

BUG=690166

Review-Url: https://codereview.chromium.org/2965063003
Cr-Commit-Position: refs/heads/master@{#486396}
Committed:
https://chromium.googlesource.com/chromium/src/+/c0ce31467ec5d9f79c3e1e069f78...
==========

[commit-bot: I haz the power, 2017-07-13 15:57:52]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c0ce31467ec5d9f79c3e1e069f78...