Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issue 2964983002: Set the background color of notification settings explicitly (Closed)

Created:
3 years, 5 months ago by yoshiki
Modified:
3 years, 5 months ago
Reviewers:
fukino
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Set the background color of notification settings explicitly Recently ScrollView has a background so we need to set a background explicitly if we want to use non-default color background. But noitification settings didn't set a background. This change solves the ugly notification settings issue (see the issue). BUG=736707 Review-Url: https://codereview.chromium.org/2964983002 Cr-Commit-Position: refs/heads/master@{#484210} Committed: https://chromium.googlesource.com/chromium/src/+/88e112a37eb251bbd487b284e80fe8cc08bef5cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/message_center/views/notifier_settings_view.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
yoshiki
Fukino-san, PTAL. Thanks.
3 years, 5 months ago (2017-07-05 06:01:23 UTC) #5
fukino
lgtm
3 years, 5 months ago (2017-07-05 06:04:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2964983002/1
3 years, 5 months ago (2017-07-05 07:30:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2964983002/1
3 years, 5 months ago (2017-07-05 07:56:15 UTC) #14
commit-bot: I haz the power
3 years, 5 months ago (2017-07-05 07:59:48 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/88e112a37eb251bbd487b284e80f...

Powered by Google App Engine
This is Rietveld 408576698