Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2964903002: Remove line break in LayoutTests/editing/selection/selection-button-text.html (Closed)

Created:
3 years, 5 months ago by yoichio
Modified:
3 years, 5 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove line break in LayoutTests/editing/selection/selection-button-text.html Selection painting with SelectAll collapses last line breaks. This should be fixed. However, there are many layout tests which have expect.png of such painting even the tests confirm another issue. This CL makes such test independent from the SelectAll behavior. BUG=739062 Review-Url: https://codereview.chromium.org/2964903002 Cr-Commit-Position: refs/heads/master@{#484077} Committed: https://chromium.googlesource.com/chromium/src/+/dcd16e1cb508aa2a8379eb489c13ab8780bda0bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/LayoutTests/editing/selection/selection-button-text.html View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
yosin_UTC9
lgtm
3 years, 5 months ago (2017-07-04 08:16:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2964903002/1
3 years, 5 months ago (2017-07-04 08:17:05 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-04 09:36:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dcd16e1cb508aa2a8379eb489c13...

Powered by Google App Engine
This is Rietveld 408576698