Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2964883002: MD Bookmarks: Fix Meta-down not triggering the 'Open' command on Mac (Closed)

Created:
3 years, 5 months ago by tsergeant
Modified:
3 years, 5 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Bookmarks: Fix Meta-down not triggering the 'Open' command on Mac This keyboard shortcut was instead being handled by the main bookmark list. BUG=738296 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2964883002 Cr-Commit-Position: refs/heads/master@{#484484} Committed: https://chromium.googlesource.com/chromium/src/+/efa15f441762bf65e0997b6990c6d71e83708cc9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/resources/md_bookmarks/list.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/md_bookmarks/command_manager_test.js View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tsergeant
3 years, 5 months ago (2017-07-06 03:03:04 UTC) #7
calamity
lgtm
3 years, 5 months ago (2017-07-06 05:28:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2964883002/1
3 years, 5 months ago (2017-07-06 05:34:58 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 06:48:23 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/efa15f441762bf65e0997b6990c6...

Powered by Google App Engine
This is Rietveld 408576698