Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 2964793002: leveldb: Use base::RepeatingCallback in DBTracker. (Closed)

Created:
3 years, 5 months ago by DmitrySkiba
Modified:
3 years, 5 months ago
Reviewers:
pwnall
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

leveldb: Use base::RepeatingCallback in DBTracker. This CL fixes accidental std::function usage in DBTracker. BUG=711518 Review-Url: https://codereview.chromium.org/2964793002 Cr-Commit-Position: refs/heads/master@{#484456} Committed: https://chromium.googlesource.com/chromium/src/+/947f697ef7cc43d8ae1d3ffea52a77b5771b8c22

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M third_party/leveldatabase/env_chromium.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 4 chunks +7 lines, -3 lines 0 comments Download
M third_party/leveldatabase/env_chromium_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (10 generated)
pwnall
LGTM w/ nit. Thank you very much for the fix! https://codereview.chromium.org/2964793002/diff/1/third_party/leveldatabase/env_chromium.h File third_party/leveldatabase/env_chromium.h (right): https://codereview.chromium.org/2964793002/diff/1/third_party/leveldatabase/env_chromium.h#newcode9 ...
3 years, 5 months ago (2017-07-06 00:49:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2964793002/20001
3 years, 5 months ago (2017-07-06 01:30:21 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 03:36:16 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/947f697ef7cc43d8ae1d3ffea52a...

Powered by Google App Engine
This is Rietveld 408576698