Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 296473002: Reland 270975: [Mac] Unselect generated password when mouse leaves password bounds. (Closed)

Created:
6 years, 7 months ago by Patrick Dubroy
Modified:
6 years, 7 months ago
Reviewers:
Adrian Kuegel
CC:
chromium-reviews
Visibility:
Public.

Description

Reland 270975: [Mac] Unselect generated password when mouse leaves password bounds. > Revert of [Mac] Unselect generated password when mouse leaves password bounds. (https://codereview.chromium.org/282093006/) > > Reason for revert: > Speculative revert, FormFillLatencyAfterSubmit is failing > > Original issue's description: > > [Mac] Unselect generated password when mouse leaves password bounds. > > > > In the Mac implementation of the password generation poup, the password > > row is not unselected when the mouse is moved elsewhere in the popup > > (e.g. over top of the help text). > > > > The fix is that PasswordSelected() should always be called in > > SetSelectionAtPoint, not just when the mouse is within the password > > bounds. The Views implementation happens to work because it has a > > subview (PasswordRow) which triggers OnMouseExited() when the mouse > > moves outside of the password bounds. > > > > Also added an optimization that PasswordSelectionUpdated() is only > > called when the value is actually changed, not every time > > PasswordSelected() is called. > > > > BUG=114092 > > R=isherman@chromium.org > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270975 > > TBR=gcasto@chromium.org,isherman@chromium.org,dubroy@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=114092 > > Review URL: https://codereview.chromium.org/287063007 TBR=akuegel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271364

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M trunk/src/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Patrick Dubroy
6 years, 7 months ago (2014-05-19 12:04:10 UTC) #1
Patrick Dubroy
Committed patchset #1 manually as r271364.
6 years, 7 months ago (2014-05-19 12:04:25 UTC) #2
Adrian Kuegel
6 years, 7 months ago (2014-05-19 12:27:57 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698