Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 287063007: Revert of [Mac] Unselect generated password when mouse leaves password bounds. (Closed)

Created:
6 years, 7 months ago by Adrian Kuegel
Modified:
6 years, 7 months ago
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, rouslan+autofillwatch_chromium.org, estade+watch_chromium.org, Ilya Sherman, mkwst+watchlist_chromium.org
Visibility:
Public.

Description

Revert of [Mac] Unselect generated password when mouse leaves password bounds. (https://codereview.chromium.org/282093006/) Reason for revert: Speculative revert, FormFillLatencyAfterSubmit is failing Original issue's description: > [Mac] Unselect generated password when mouse leaves password bounds. > > In the Mac implementation of the password generation poup, the password > row is not unselected when the mouse is moved elsewhere in the popup > (e.g. over top of the help text). > > The fix is that PasswordSelected() should always be called in > SetSelectionAtPoint, not just when the mouse is within the password > bounds. The Views implementation happens to work because it has a > subview (PasswordRow) which triggers OnMouseExited() when the mouse > moves outside of the password bounds. > > Also added an optimization that PasswordSelectionUpdated() is only > called when the value is actually changed, not every time > PasswordSelected() is called. > > BUG=114092 > R=isherman@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270975 TBR=gcasto@chromium.org,isherman@chromium.org,dubroy@chromium.org NOTREECHECKS=true NOTRY=true BUG=114092 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271001

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Adrian Kuegel
Created Revert of [Mac] Unselect generated password when mouse leaves password bounds.
6 years, 7 months ago (2014-05-16 12:21:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/287063007/1
6 years, 7 months ago (2014-05-16 12:21:57 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 12:23:26 UTC) #3
Message was sent while issue was closed.
Change committed as 271001

Powered by Google App Engine
This is Rietveld 408576698