media: Add more player details in chrome://media-internals player list

media: Add more player details in chrome://media-internals player list

Buttons now contain:
  [player src or ID]
  [frame title] - [frame url]
  [resolution, codecs] [last event]

Screenshot: http://i.imgur.com/ue2ibQJ.png

Also removes the kCreated event from PipelineImpl. After this change,
the first event reported by every MediaLog is WEBMEDIAPLAYER_CREATED,
and we will be able to use that to improve log expiry.

BUG=551065
Review-Url: https://codereview.chromium.org/2964713004
Cr-Commit-Position: refs/heads/master@{#485093}
Committed: https://chromium.googlesource.com/chromium/src/+/72683f2505affd84d0a32f5f6a9c5bc1965cfe41

[sandersd (OOO until July 31), 2017-06-30 23:26:56]

sandersd@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[sandersd (OOO until July 31), 2017-06-30 23:27:24]

Description was changed from

==========
media: Add more player details in chrome://media-internals player list

Buttons now contain:
  [player src or ID]
  [frame title] - [frame url]
  [resolution, codecs] [last event]

Also removed the kCreated event from PipelineImpl. After that change,
the first event reported by every MediaLog is WEBMEDIAPLAYER_CREATED,
and we will be able to use that to improve log exiary.

BUG=551065
==========

to

==========
media: Add more player details in chrome://media-internals player list

Buttons now contain:
  [player src or ID]
  [frame title] - [frame url]
  [resolution, codecs] [last event]

Also removed the kCreated event from PipelineImpl. After this change,
the first event reported by every MediaLog is WEBMEDIAPLAYER_CREATED,
and we will be able to use that to improve log expiry.

BUG=551065
==========

[DaleCurtis, 2017-06-30 23:35:43]

Can you add some screen shots to this?

[sandersd (OOO until July 31), 2017-06-30 23:51:43]

Description was changed from

==========
media: Add more player details in chrome://media-internals player list

Buttons now contain:
  [player src or ID]
  [frame title] - [frame url]
  [resolution, codecs] [last event]

Also removed the kCreated event from PipelineImpl. After this change,
the first event reported by every MediaLog is WEBMEDIAPLAYER_CREATED,
and we will be able to use that to improve log expiry.

BUG=551065
==========

to

==========
media: Add more player details in chrome://media-internals player list

Buttons now contain:
  [player src or ID]
  [frame title] - [frame url]
  [resolution, codecs] [last event]

Screenshot: http://imgur.com/khQKe9H.png

Also removed the kCreated event from PipelineImpl. After this change,
the first event reported by every MediaLog is WEBMEDIAPLAYER_CREATED,
and we will be able to use that to improve log expiry.

BUG=551065
==========

[DaleCurtis, 2017-07-01 00:08:05]

Code wise lgtm; feel free to land style changes in a follow up or in here.

https://codereview.chromium.org/2964713004/diff/40001/content/browser/resourc...
File content/browser/resources/media/client_renderer.js (right):

https://codereview.chromium.org/2964713004/diff/40001/content/browser/resourc...
content/browser/resources/media/client_renderer.js:74: if (isDestructed ===
true)
is === true/false really necessary?

https://codereview.chromium.org/2964713004/diff/40001/content/browser/resourc...
content/browser/resources/media/client_renderer.js:181: if (key === 'url' || key
=== 'frame.url' || key === 'frame.title' ||
Maybe just create an array of these and use REQUIRED_KEYS.contains(key) ?

[sandersd (OOO until July 31), 2017-07-01 00:52:03]

https://codereview.chromium.org/2964713004/diff/40001/content/browser/resourc...
File content/browser/resources/media/client_renderer.js (right):

https://codereview.chromium.org/2964713004/diff/40001/content/browser/resourc...
content/browser/resources/media/client_renderer.js:74: if (isDestructed ===
true)
On 2017/07/01 00:08:04, DaleCurtis wrote:
> is === true/false really necessary?

It was, to distinguish undefined, but I've removed that case now.

https://codereview.chromium.org/2964713004/diff/40001/content/browser/resourc...
content/browser/resources/media/client_renderer.js:181: if (key === 'url' || key
=== 'frame.url' || key === 'frame.title' ||
On 2017/07/01 00:08:04, DaleCurtis wrote:
> Maybe just create an array of these and use REQUIRED_KEYS.contains(key) ?

Done.

[sandersd (OOO until July 31), 2017-07-01 00:52:30]

Description was changed from

==========
media: Add more player details in chrome://media-internals player list

Buttons now contain:
  [player src or ID]
  [frame title] - [frame url]
  [resolution, codecs] [last event]

Screenshot: http://imgur.com/khQKe9H.png

Also removed the kCreated event from PipelineImpl. After this change,
the first event reported by every MediaLog is WEBMEDIAPLAYER_CREATED,
and we will be able to use that to improve log expiry.

BUG=551065
==========

to

==========
media: Add more player details in chrome://media-internals player list

Buttons now contain:
  [player src or ID]
  [frame title] - [frame url]
  [resolution, codecs] [last event]

Screenshot: http://imgur.com/a/CBNGt.png

Also removed the kCreated event from PipelineImpl. After this change,
the first event reported by every MediaLog is WEBMEDIAPLAYER_CREATED,
and we will be able to use that to improve log expiry.

BUG=551065
==========

[sandersd (OOO until July 31), 2017-07-01 00:53:02]

Description was changed from

==========
media: Add more player details in chrome://media-internals player list

Buttons now contain:
  [player src or ID]
  [frame title] - [frame url]
  [resolution, codecs] [last event]

Screenshot: http://imgur.com/a/CBNGt.png

Also removed the kCreated event from PipelineImpl. After this change,
the first event reported by every MediaLog is WEBMEDIAPLAYER_CREATED,
and we will be able to use that to improve log expiry.

BUG=551065
==========

to

==========
media: Add more player details in chrome://media-internals player list

Buttons now contain:
  [player src or ID]
  [frame title] - [frame url]
  [resolution, codecs] [last event]

Screenshot: http://imgur.com/9yj3hlu.png

Also removed the kCreated event from PipelineImpl. After this change,
the first event reported by every MediaLog is WEBMEDIAPLAYER_CREATED,
and we will be able to use that to improve log expiry.

BUG=551065
==========

[DaleCurtis, 2017-07-06 17:11:22]

Is the screenshot up to date with colors? I.e. light/dark grey mixing? I'll look
for some alternate colors if you didn't find any.

[sandersd (OOO until July 31), 2017-07-06 17:21:50]

On 2017/07/06 17:11:22, DaleCurtis wrote:
> Is the screenshot up to date with colors? I.e. light/dark grey mixing? I'll
look
> for some alternate colors if you didn't find any.

The colors are up to date; dark grey is for destroyed players. If you go too far
it looks like it is disabled, which implies that you can't click it.

[sandersd (OOO until July 31), 2017-07-06 23:21:54]

Description was changed from

==========
media: Add more player details in chrome://media-internals player list

Buttons now contain:
  [player src or ID]
  [frame title] - [frame url]
  [resolution, codecs] [last event]

Screenshot: http://imgur.com/9yj3hlu.png

Also removed the kCreated event from PipelineImpl. After this change,
the first event reported by every MediaLog is WEBMEDIAPLAYER_CREATED,
and we will be able to use that to improve log expiry.

BUG=551065
==========

to

==========
media: Add more player details in chrome://media-internals player list

Buttons now contain:
  [player src or ID]
  [frame title] - [frame url]
  [resolution, codecs] [last event]

Screenshot: http://i.imgur.com/ue2ibQJ.png

Also removes the kCreated event from PipelineImpl. After this change,
the first event reported by every MediaLog is WEBMEDIAPLAYER_CREATED,
and we will be able to use that to improve log expiry.

BUG=551065
==========

[sandersd (OOO until July 31), 2017-07-07 21:16:57]

The CQ bit was checked by sandersd@chromium.org

[sandersd (OOO until July 31), 2017-07-07 21:16:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2964713004/#ps80001
(title: "Bikeshed.")

[commit-bot: I haz the power, 2017-07-07 21:17:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 23:20:49]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499462217880170,
"parent_rev": "2b5417ac028acd75faefeabd7102c6ebc37772f2", "commit_rev":
"72683f2505affd84d0a32f5f6a9c5bc1965cfe41"}

[commit-bot: I haz the power, 2017-07-07 23:21:17]

Description was changed from

==========
media: Add more player details in chrome://media-internals player list

Buttons now contain:
  [player src or ID]
  [frame title] - [frame url]
  [resolution, codecs] [last event]

Screenshot: http://i.imgur.com/ue2ibQJ.png

Also removes the kCreated event from PipelineImpl. After this change,
the first event reported by every MediaLog is WEBMEDIAPLAYER_CREATED,
and we will be able to use that to improve log expiry.

BUG=551065
==========

to

==========
media: Add more player details in chrome://media-internals player list

Buttons now contain:
  [player src or ID]
  [frame title] - [frame url]
  [resolution, codecs] [last event]

Screenshot: http://i.imgur.com/ue2ibQJ.png

Also removes the kCreated event from PipelineImpl. After this change,
the first event reported by every MediaLog is WEBMEDIAPLAYER_CREATED,
and we will be able to use that to improve log expiry.

BUG=551065

Review-Url: https://codereview.chromium.org/2964713004
Cr-Commit-Position: refs/heads/master@{#485093}
Committed:
https://chromium.googlesource.com/chromium/src/+/72683f2505affd84d0a32f5f6a9c...
==========

[commit-bot: I haz the power, 2017-07-07 23:21:19]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/72683f2505affd84d0a32f5f6a9c...