Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3813)

Unified Diff: components/safe_browsing/features.h

Issue 2964693003: Added experiments section and exported the list of SafeBrowsing features in WebUI (Closed)
Patch Set: Changed the location of features.cc/.h Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/features.h
diff --git a/components/safe_browsing/features.h b/components/safe_browsing/features.h
new file mode 100644
index 0000000000000000000000000000000000000000..31f4bf098385e96cce07ef64b3dd218c004fa10c
--- /dev/null
+++ b/components/safe_browsing/features.h
@@ -0,0 +1,24 @@
+// Copyright (c) 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+#ifndef COMPONENTS_SAFE_BROWSING_FEATURES_H_
vakh (use Gerrit instead) 2017/07/07 00:23:40 Please leave some blank lines between the copyrigh
hkamila 2017/07/07 01:29:49 Acknowledged.
+#define COMPONENTS_SAFE_BROWSING_FEATURES_H_
Jialiu Lin 2017/07/06 23:58:27 nit: Add an empty line under #define
hkamila 2017/07/07 01:29:49 Acknowledged.
+#include <stddef.h>
+#include <algorithm>
+#include <utility>
+#include <vector>
+#include "base/feature_list.h"
Jialiu Lin 2017/07/06 23:58:27 nit: a blank line before #include "base/feature_li
hkamila 2017/07/07 01:29:49 Acknowledged.
+#include "base/macros.h"
+#include "base/values.h"
+namespace base {
+class ListValue;
+} // namespace base
+
Jialiu Lin 2017/07/06 23:58:27 maybe put this class into safe_browsing namespace?
hkamila 2017/07/07 01:29:49 Acknowledged.
+// Features list
+extern const base::Feature kLocalDatabaseManagerEnabled;
+extern const base::Feature kV4OnlyEnabled;
+extern const base::Feature kThreatDomDetailsTagAndAttributeFeature;
+
+base::ListValue GetTrueParametersList();
+
+#endif // COMPONENTS_SAFE_BROWSING_FEATURES_H_

Powered by Google App Engine
This is Rietveld 408576698