components/safe_browsing/features.h - Issue 2964693003: Added experiments section and exported the list of SafeBrowsing features in WebUI

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/safe_browsing/features.h

Issue 2964693003: Added experiments section and exported the list of SafeBrowsing features in WebUI (Closed)

Patch Set: Changed the location of features.cc/.h Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/safe_browsing/common/safe_browsing_prefs.cc ('K') | « components/safe_browsing/common/safe_browsing_prefs.cc ('k') | components/safe_browsing/features.cc » ('j') | components/safe_browsing/features.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4 #ifndef COMPONENTS_SAFE_BROWSING_FEATURES_H_
	vakh (use Gerrit instead) 2017/07/07 00:23:40 Please leave some blank lines between the copyrigh Please leave some blank lines between the copyright comment, header, etc. See: https://cs.chromium.org/chromium/src/components/safe_browsing_db/v4_store.cc hkamila 2017/07/07 01:29:49 Acknowledged. Show quoted text On 2017/07/07 00:23:40, vakh (use Gerrit instead) wrote: > Please leave some blank lines between the copyright comment, header, etc. > See: > https://cs.chromium.org/chromium/src/components/safe_browsing_db/v4_store.cc Acknowledged.
	5 #define COMPONENTS_SAFE_BROWSING_FEATURES_H_
	Jialiu Lin 2017/07/06 23:58:27 nit: Add an empty line under #define nit: Add an empty line under #define hkamila 2017/07/07 01:29:49 Acknowledged. Show quoted text On 2017/07/06 23:58:27, Jialiu Lin wrote: > nit: Add an empty line under #define Acknowledged.
	6 #include <stddef.h>

	7 #include <algorithm>

	8 #include <utility>

	9 #include <vector>

	10 #include "base/feature_list.h"
	Jialiu Lin 2017/07/06 23:58:27 nit: a blank line before #include "base/feature_li nit: a blank line before #include "base/feature_list.h" hkamila 2017/07/07 01:29:49 Acknowledged. Show quoted text On 2017/07/06 23:58:27, Jialiu Lin wrote: > nit: a blank line before #include "base/feature_list.h" Acknowledged.
	11 #include "base/macros.h"

	12 #include "base/values.h"

	13 namespace base {

	14 class ListValue;

	15 } // namespace base

	16
	Jialiu Lin 2017/07/06 23:58:27 maybe put this class into safe_browsing namespace? maybe put this class into safe_browsing namespace? hkamila 2017/07/07 01:29:49 Acknowledged. Show quoted text On 2017/07/06 23:58:27, Jialiu Lin wrote: > maybe put this class into safe_browsing namespace? Acknowledged.
	17 // Features list

	18 extern const base::Feature kLocalDatabaseManagerEnabled;

	19 extern const base::Feature kV4OnlyEnabled;

	20 extern const base::Feature kThreatDomDetailsTagAndAttributeFeature;

	21

	22 base::ListValue GetTrueParametersList();

	23

	24 #endif // COMPONENTS_SAFE_BROWSING_FEATURES_H_

OLD	NEW