drive: Stop using FileCacheEntry related methods in FileCache

drive: Stop using FileCacheEntry related methods in FileCache

Remove ResourceMetadataStorage::PutCacheEntry, RemoveCacheEntry and GetCacheEntryIterator. (GetCacheEntry is kept for tests)
FileCache::ClearAll is only responsible to delete files.

BUG=275271
TEST=unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271664

[kinaba, 2014-05-19 08:22:54]

https://codereview.chromium.org/296463002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/resource_metadata_storage.cc (right):

https://codereview.chromium.org/296463002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/resource_metadata_storage.cc:613:
batch.Delete(GetCacheEntryKey(id));
Wouldn't it be problematic when old_entry had cache info but the new entry
(which for instance came from ResourceMetadata::RefreshEntry) did not?

[hashimoto, 2014-05-20 02:46:33]

https://codereview.chromium.org/296463002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/resource_metadata_storage.cc (right):

https://codereview.chromium.org/296463002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/resource_metadata_storage.cc:613:
batch.Delete(GetCacheEntryKey(id));
On 2014/05/19 08:22:54, kinaba wrote:
> Wouldn't it be problematic when old_entry had cache info but the new entry
> (which for instance came from ResourceMetadata::RefreshEntry) did not?

You're right.
I should have addressed it first, but it slipped off of my mind for some reason.
Thanks, modified RefreshEntry.

[kinaba, 2014-05-20 08:48:48]

lgtm

[hashimoto, 2014-05-20 08:55:09]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-05-20 08:55:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/296463002/60001

[commit-bot: I haz the power, 2014-05-20 10:37:56]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[commit-bot: I haz the power, 2014-05-20 15:45:23]

Change committed as 271664