Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 296463002: drive: Stop using FileCacheEntry related methods in FileCache (Closed)

Created:
6 years, 7 months ago by hashimoto
Modified:
6 years, 7 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Stop using FileCacheEntry related methods in FileCache Remove ResourceMetadataStorage::PutCacheEntry, RemoveCacheEntry and GetCacheEntryIterator. (GetCacheEntry is kept for tests) FileCache::ClearAll is only responsible to delete files. BUG=275271 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271664

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Do not overwrite cache state with RefreshEntry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -334 lines) Patch
M chrome/browser/chromeos/drive/file_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_cache.cc View 14 chunks +86 lines, -83 lines 0 comments Download
M chrome/browser/chromeos/drive/file_cache_unittest.cc View 20 chunks +77 lines, -50 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata.cc View 1 1 chunk +10 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage.cc View 5 chunks +4 lines, -93 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage_unittest.cc View 8 chunks +3 lines, -97 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_unittest.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hashimoto
6 years, 7 months ago (2014-05-19 08:09:23 UTC) #1
kinaba
https://codereview.chromium.org/296463002/diff/20001/chrome/browser/chromeos/drive/resource_metadata_storage.cc File chrome/browser/chromeos/drive/resource_metadata_storage.cc (right): https://codereview.chromium.org/296463002/diff/20001/chrome/browser/chromeos/drive/resource_metadata_storage.cc#newcode613 chrome/browser/chromeos/drive/resource_metadata_storage.cc:613: batch.Delete(GetCacheEntryKey(id)); Wouldn't it be problematic when old_entry had cache ...
6 years, 7 months ago (2014-05-19 08:22:54 UTC) #2
hashimoto
https://codereview.chromium.org/296463002/diff/20001/chrome/browser/chromeos/drive/resource_metadata_storage.cc File chrome/browser/chromeos/drive/resource_metadata_storage.cc (right): https://codereview.chromium.org/296463002/diff/20001/chrome/browser/chromeos/drive/resource_metadata_storage.cc#newcode613 chrome/browser/chromeos/drive/resource_metadata_storage.cc:613: batch.Delete(GetCacheEntryKey(id)); On 2014/05/19 08:22:54, kinaba wrote: > Wouldn't it ...
6 years, 7 months ago (2014-05-20 02:46:33 UTC) #3
kinaba
lgtm
6 years, 7 months ago (2014-05-20 08:48:48 UTC) #4
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 7 months ago (2014-05-20 08:55:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/296463002/60001
6 years, 7 months ago (2014-05-20 08:55:47 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 10:37:56 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 15:45:23 UTC) #8
Message was sent while issue was closed.
Change committed as 271664

Powered by Google App Engine
This is Rietveld 408576698