Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: chrome/browser/chromeos/drive/resource_metadata_unittest.cc

Issue 296463002: drive: Stop using FileCacheEntry related methods in FileCache (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Do not overwrite cache state with RefreshEntry Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/drive/resource_metadata_storage_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/drive/resource_metadata_unittest.cc
diff --git a/chrome/browser/chromeos/drive/resource_metadata_unittest.cc b/chrome/browser/chromeos/drive/resource_metadata_unittest.cc
index 3df321466f4569139e1f595c00638d567cbe7750..9f96e68b0821e176379593f22779c28faffce125 100644
--- a/chrome/browser/chromeos/drive/resource_metadata_unittest.cc
+++ b/chrome/browser/chromeos/drive/resource_metadata_unittest.cc
@@ -352,6 +352,35 @@ TEST_F(ResourceMetadataTest, RefreshEntry_ResourceIDCheck) {
resource_metadata_->RefreshEntry(new_entry));
}
+TEST_F(ResourceMetadataTest, RefreshEntry_DoNotOverwriteCacheState) {
+ ResourceEntry entry;
+ EXPECT_EQ(FILE_ERROR_OK, resource_metadata_->GetResourceEntryByPath(
+ base::FilePath::FromUTF8Unsafe("drive/root/dir1/file4"), &entry));
+
+ // Try to set MD5 with RefreshEntry.
+ entry.mutable_file_specific_info()->mutable_cache_state()->set_md5("md5");
+ EXPECT_EQ(FILE_ERROR_OK, resource_metadata_->RefreshEntry(entry));
+
+ // Cache state is unchanged.
+ EXPECT_EQ(FILE_ERROR_OK, resource_metadata_->GetResourceEntryByPath(
+ base::FilePath::FromUTF8Unsafe("drive/root/dir1/file4"), &entry));
+ EXPECT_TRUE(entry.file_specific_info().cache_state().md5().empty());
+
+ // Pin the file.
+ EXPECT_EQ(FILE_ERROR_OK, cache_->Pin(entry.local_id()));
+
+ // Try to clear the cache state with RefreshEntry.
+ EXPECT_EQ(FILE_ERROR_OK, resource_metadata_->GetResourceEntryByPath(
+ base::FilePath::FromUTF8Unsafe("drive/root/dir1/file4"), &entry));
+ entry.mutable_file_specific_info()->clear_cache_state();
+ EXPECT_EQ(FILE_ERROR_OK, resource_metadata_->RefreshEntry(entry));
+
+ // Cache state is not cleared.
+ EXPECT_EQ(FILE_ERROR_OK, resource_metadata_->GetResourceEntryByPath(
+ base::FilePath::FromUTF8Unsafe("drive/root/dir1/file4"), &entry));
+ EXPECT_TRUE(entry.file_specific_info().cache_state().is_pinned());
+}
+
TEST_F(ResourceMetadataTest, GetSubDirectoriesRecursively) {
std::set<base::FilePath> sub_directories;
« no previous file with comments | « chrome/browser/chromeos/drive/resource_metadata_storage_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698