Issue 2964583003: Fix incorrect DBC code generation of range-based CheckClassId

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2964583003: Fix incorrect DBC code generation of range-based CheckClassId (Closed)

Created:
3 years, 5 months ago by alexmarkov

Modified:
3 years, 5 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix incorrect DBC code generation of range-based CheckClassId CheckClassId IL instructions with ranges of Cids were incorrectly generated to DBC: instead of embedding range length directly into the Nop, a constant was added into an object pool and index of the constant was stored in Nop. Closes https://github.com/dart-lang/sdk/issues/29846 R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/499a5870037a5699c07c643bc3ae8b7f7add9f21

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -1 line)			Patch
	A	runtime/tests/vm/dart/regress29846_test.dart	View		1 chunk	+60 lines, -0 lines	0 comments	Download
	M	runtime/vm/intermediate_language_dbc.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

alexmarkov

3 years, 5 months ago (2017-06-29 22:32:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
499a5870037a5699c07c643bc3ae8b7f7add9f21 (presubmit successful).