Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: runtime/vm/intermediate_language_dbc.cc

Issue 2964583003: Fix incorrect DBC code generation of range-based CheckClassId (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/tests/vm/dart/regress29846_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_dbc.cc
diff --git a/runtime/vm/intermediate_language_dbc.cc b/runtime/vm/intermediate_language_dbc.cc
index 00142af0cb1e7ebfc5964a0d64a205d2c04cb0c2..3d1aa2fff0aaf6f65225852be8aa10c17045a0c8 100644
--- a/runtime/vm/intermediate_language_dbc.cc
+++ b/runtime/vm/intermediate_language_dbc.cc
@@ -1500,7 +1500,7 @@ EMIT_NATIVE_CODE(CheckClassId, 1) {
} else {
__ CheckClassIdRange(locs()->in(0).reg(),
compiler->ToEmbeddableCid(cids_.cid_start, this));
- __ Nop(__ AddConstant(Smi::Handle(Smi::New(cids_.Extent()))));
+ __ Nop(compiler->ToEmbeddableCid(cids_.Extent(), this));
}
compiler->EmitDeopt(deopt_id(), ICData::kDeoptCheckClass);
}
« no previous file with comments | « runtime/tests/vm/dart/regress29846_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698