Avoid constexpr compiler bug in VS 2017

Avoid constexpr compiler bug in VS 2017

The constexpr definition of kStaleFrameLimit in a lambda triggered an
internal compiler error in VS 2017. A bug is being filed but we want to
unblock VS 2017 builds while waiting for a fix.

Moving the definition to the global scope is safe and efficient because
it is still constexpr, so it just uses a bit of const space.

This bug was triggered by crrev.com/c/546917. A VS compiler bug was
filed here:
https://developercommunity.visualstudio.com/content/problem/74761/ice-on-constexpr-in-lambda-in-update-3-of-preview.html

BUG=683729
Review-Url: https://codereview.chromium.org/2964573002
Cr-Commit-Position: refs/heads/master@{#483536}
Committed: https://chromium.googlesource.com/chromium/src/+/60ce12e4bf84419b990ae44ebb876b727edce313

[brucedawson, 2017-06-29 20:15:48]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 20:16:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-06-29 20:17:10]

brucedawson@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[brucedawson, 2017-06-29 20:17:11]

Your change yesterday triggered a VS 2017 compiler bug. How does this workaround
look?

The workaround is benign enough that I didn't think it was worth doing any
comments or version checks around it. I'm working on reducing the repro and
filing a VS bug right now.

[DaleCurtis, 2017-06-29 20:22:41]

Hah, exciting. lgtm

[brucedawson, 2017-06-29 21:00:09]

Description was changed from

==========
Avoid constexpr compiler bug in VS 2017

The constexpr definition of kStaleFrameLimit in a lambda triggered an
internal compiler error in VS 2017. A bug is being filed but we want to
unblock VS 2017 builds while waiting for a fix.

Moving the definition to the global scope is safe and efficient because
it is still constexpr, so it just uses a bit of const space.

This bug was triggered by crrev.com/c/546917.

BUG=683729
==========

to

==========
Avoid constexpr compiler bug in VS 2017

The constexpr definition of kStaleFrameLimit in a lambda triggered an
internal compiler error in VS 2017. A bug is being filed but we want to
unblock VS 2017 builds while waiting for a fix.

Moving the definition to the global scope is safe and efficient because
it is still constexpr, so it just uses a bit of const space.

This bug was triggered by crrev.com/c/546917. A VS compiler bug was
filed here:
https://developercommunity.visualstudio.com/content/problem/74761/ice-on-cons...

BUG=683729
==========

[commit-bot: I haz the power, 2017-06-29 22:21:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 22:21:36]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2017-06-29 23:10:21]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-06-29 23:10:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 23:14:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498777821871170, "parent_rev":
"14a3f223996a875cee52cea58d8c036edafb8dfc", "commit_rev":
"60ce12e4bf84419b990ae44ebb876b727edce313"}

[commit-bot: I haz the power, 2017-06-29 23:14:59]

Description was changed from

==========
Avoid constexpr compiler bug in VS 2017

The constexpr definition of kStaleFrameLimit in a lambda triggered an
internal compiler error in VS 2017. A bug is being filed but we want to
unblock VS 2017 builds while waiting for a fix.

Moving the definition to the global scope is safe and efficient because
it is still constexpr, so it just uses a bit of const space.

This bug was triggered by crrev.com/c/546917. A VS compiler bug was
filed here:
https://developercommunity.visualstudio.com/content/problem/74761/ice-on-cons...

BUG=683729
==========

to

==========
Avoid constexpr compiler bug in VS 2017

The constexpr definition of kStaleFrameLimit in a lambda triggered an
internal compiler error in VS 2017. A bug is being filed but we want to
unblock VS 2017 builds while waiting for a fix.

Moving the definition to the global scope is safe and efficient because
it is still constexpr, so it just uses a bit of const space.

This bug was triggered by crrev.com/c/546917. A VS compiler bug was
filed here:
https://developercommunity.visualstudio.com/content/problem/74761/ice-on-cons...

BUG=683729

Review-Url: https://codereview.chromium.org/2964573002
Cr-Commit-Position: refs/heads/master@{#483536}
Committed:
https://chromium.googlesource.com/chromium/src/+/60ce12e4bf84419b990ae44ebb87...
==========

[commit-bot: I haz the power, 2017-06-29 23:15:01]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/60ce12e4bf84419b990ae44ebb87...