Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2964523003: Copy dbgcore.dll to the build directory. (Closed)

Created:
3 years, 5 months ago by Sébastien Marchand
Modified:
3 years, 5 months ago
Reviewers:
brucedawson, inferno
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Copy dbgcore.dll to the build directory. dbghelp.dll apparently has some dependencies on dbgcore.dll, which isn't available on the Clusterfuzz bots (and probably on the trybots as well). BUG=738088 Review-Url: https://codereview.chromium.org/2964523003 Cr-Commit-Position: refs/heads/master@{#483516} Committed: https://chromium.googlesource.com/chromium/src/+/475258923fee8ee38edbcd4ad1a86bc5ef6f286a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M build/vs_toolchain.py View 2 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Sébastien Marchand
PTAL.
3 years, 5 months ago (2017-06-29 20:56:52 UTC) #2
brucedawson
lgtm
3 years, 5 months ago (2017-06-29 21:41:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2964523003/1
3 years, 5 months ago (2017-06-29 22:21:00 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 22:25:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/475258923fee8ee38edbcd4ad1a8...

Powered by Google App Engine
This is Rietveld 408576698