Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: ios/public/provider/chrome/browser/signin/chrome_identity_interaction_manager.mm

Issue 2964383002: [ObjC ARC] Converts ios/public/provider/chrome/browser/signin:signin to ARC. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/public/provider/chrome/browser/signin/chrome_identity_interaction_manager.mm
diff --git a/ios/public/provider/chrome/browser/signin/chrome_identity_interaction_manager.mm b/ios/public/provider/chrome/browser/signin/chrome_identity_interaction_manager.mm
index 6e5b223dd24e65a4fdb8970a510764888b01f090..efa66680d97aaf919741a300b49d536e4b07a7d1 100644
--- a/ios/public/provider/chrome/browser/signin/chrome_identity_interaction_manager.mm
+++ b/ios/public/provider/chrome/browser/signin/chrome_identity_interaction_manager.mm
@@ -4,11 +4,14 @@
#import "ios/public/provider/chrome/browser/signin/chrome_identity_interaction_manager.h"
-#import "base/ios/weak_nsobject.h"
#include "base/logging.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
@interface ChromeIdentityInteractionManager () {
- base::WeakNSProtocol<id<ChromeIdentityInteractionManagerDelegate>> _delegate;
+ __weak id<ChromeIdentityInteractionManagerDelegate> _delegate;
msarda 2017/07/03 16:14:43 Remove this and use a synthesized weak property.
stkhapugin 2017/07/11 13:14:42 Done.
}
@end
@@ -19,7 +22,7 @@
}
- (void)setDelegate:(id<ChromeIdentityInteractionManagerDelegate>)delegate {
msarda 2017/07/03 16:14:42 Remove this set now that the delegate is a regular
stkhapugin 2017/07/11 13:14:42 Done.
- _delegate.reset(delegate);
+ _delegate = delegate;
}
- (BOOL)isCanceling {

Powered by Google App Engine
This is Rietveld 408576698