Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: ios/public/provider/chrome/browser/signin/chrome_identity.h

Issue 2964383002: [ObjC ARC] Converts ios/public/provider/chrome/browser/signin:signin to ARC. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/public/provider/chrome/browser/signin/chrome_identity.h
diff --git a/ios/public/provider/chrome/browser/signin/chrome_identity.h b/ios/public/provider/chrome/browser/signin/chrome_identity.h
index d427bd4d0c34e3923c956c0ca09efd270df9bf5c..a48dd149b5183fddff49233fa500d9b41a87fe2c 100644
--- a/ios/public/provider/chrome/browser/signin/chrome_identity.h
+++ b/ios/public/provider/chrome/browser/signin/chrome_identity.h
@@ -14,19 +14,19 @@
// Identity/account email address. This can be shown to the user, but is not a
// unique identifier (@see gaiaID).
-@property(nonatomic, readonly) NSString* userEmail;
+@property(weak, nonatomic, readonly) NSString* userEmail;
msarda 2017/07/03 16:14:42 I think these should be strong from an API perspec
stkhapugin 2017/07/11 13:14:42 Done.
// The unique GAIA user identifier for this identity/account.
// You may use this as a unique identifier to remember a particular identity.
-@property(nonatomic, readonly) NSString* gaiaID;
+@property(weak, nonatomic, readonly) NSString* gaiaID;
// Returns the full name of the identity.
// Could be nil if no full name has been fetched for this account yet.
-@property(nonatomic, readonly) NSString* userFullName;
+@property(weak, nonatomic, readonly) NSString* userFullName;
// Cached Hashed Gaia ID. This is used to pass the currently signed in account
// between apps.
-@property(nonatomic, readonly) NSString* hashedGaiaID;
+@property(weak, nonatomic, readonly) NSString* hashedGaiaID;
@end

Powered by Google App Engine
This is Rietveld 408576698