Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1556)

Unified Diff: components/certificate_reporting/error_report.cc

Issue 2964283002: Add chrome channel to cert logger reports (Closed)
Patch Set: Revert unneeded change Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/certificate_reporting/error_report.cc
diff --git a/components/certificate_reporting/error_report.cc b/components/certificate_reporting/error_report.cc
index ebc41f55a7b708a7450cbc920a6cd3701682d299..758c74114a1ff99dcbae3200bce9fd664f543de1 100644
--- a/components/certificate_reporting/error_report.cc
+++ b/components/certificate_reporting/error_report.cc
@@ -174,6 +174,36 @@ void ErrorReport::AddNetworkTimeInfo(
network_time_info->set_network_time_query_behavior(report_behavior);
}
+void ErrorReport::AddChromeChannel(version_info::Channel channel) {
+ CertLoggerRequest::ChromeChannel code;
+ switch (channel) {
+ case version_info::Channel::STABLE:
+ code = CertLoggerRequest::STABLE;
+ break;
+
+ case version_info::Channel::BETA:
+ code = CertLoggerRequest::BETA;
+ break;
+
+ case version_info::Channel::CANARY:
+ code = CertLoggerRequest::CANARY;
+ break;
+
+ case version_info::Channel::DEV:
+ code = CertLoggerRequest::DEV;
+ break;
+
+ case version_info::Channel::UNKNOWN:
+ code = CertLoggerRequest::UNKNOWN;
+ break;
+
+ default:
estark 2017/07/01 17:19:01 I think you can delete this case. (Better to leave
sperigo 2017/07/05 23:02:48 This is really smart. Thanks!
sperigo 2017/07/05 23:02:48 Done.
+ code = CertLoggerRequest::NONE;
+ break;
+ }
+ cert_report_->set_chrome_channel(code);
+}
+
void ErrorReport::SetIsRetryUpload(bool is_retry_upload) {
cert_report_->set_is_retry_upload(is_retry_upload);
}

Powered by Google App Engine
This is Rietveld 408576698