Add chrome channel to cert logger reports

components/certificate_reporting/error_report.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/certificate_reporting/error_report.h"
 
 #include <vector>
 
 #include "base/stl_util.h"
 #include "base/strings/string_util.h"
@@ skipping 156 matching lines @@
           NETWORK_TIME_FETCHES_ON_DEMAND_ONLY;
       break;
     case NetworkTimeTracker::FETCHES_IN_BACKGROUND_AND_ON_DEMAND:
       report_behavior = CertLoggerFeaturesInfo::NetworkTimeQueryingInfo::
           NETWORK_TIME_FETCHES_IN_BACKGROUND_AND_ON_DEMAND;
       break;
   }
   network_time_info->set_network_time_query_behavior(report_behavior);
 }
 
+void ErrorReport::AddChromeChannel(version_info::Channel channel) {
+  CertLoggerRequest::ChromeChannel code;
+  switch (channel) {
+    case version_info::Channel::STABLE:
+      code = CertLoggerRequest::STABLE;
+      break;
+
+    case version_info::Channel::BETA:
+      code = CertLoggerRequest::BETA;
+      break;
+
+    case version_info::Channel::CANARY:
+      code = CertLoggerRequest::CANARY;
+      break;
+
+    case version_info::Channel::DEV:
+      code = CertLoggerRequest::DEV;
+      break;
+
+    case version_info::Channel::UNKNOWN:
+      code = CertLoggerRequest::UNKNOWN;
+      break;
+
+    default:

[estark, 2017/07/01 17:19:01]

I think you can delete this case. (Better to leave off default when you can
because then if someone comes along and adds a new value, this won't compile
unless the new value is explicitly handled.)

[sperigo, 2017/07/05 23:02:48]

This is really smart. Thanks!

[sperigo, 2017/07/05 23:02:48]

Done.

+      code = CertLoggerRequest::NONE;
+      break;
+  }
+  cert_report_->set_chrome_channel(code);
+}
+
 void ErrorReport::SetIsRetryUpload(bool is_retry_upload) {
   cert_report_->set_is_retry_upload(is_retry_upload);
 }
 
 const std::string& ErrorReport::hostname() const {
   return cert_report_->hostname();
 }
 
 bool ErrorReport::is_retry_upload() const {
   return cert_report_->is_retry_upload();
 }
 
 }  // namespace certificate_reporting