Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: components/certificate_reporting/error_report.h

Issue 2964283002: Add chrome channel to cert logger reports (Closed)
Patch Set: Clean up test comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/certificate_reporting/error_report.h
diff --git a/components/certificate_reporting/error_report.h b/components/certificate_reporting/error_report.h
index 0d611db40ebd0dfe30edd0101c25f619629845e4..3b9f0e29c93d9c9049aad78bd156e2b5837847f8 100644
--- a/components/certificate_reporting/error_report.h
+++ b/components/certificate_reporting/error_report.h
@@ -20,6 +20,10 @@ namespace net {
class SSLInfo;
} // namespace net
+namespace version_info {
+enum class Channel;
+}
meacer 2017/06/30 22:24:46 You'll want to include version_info instead of for
sperigo 2017/06/30 23:37:28 Done.
+
namespace certificate_reporting {
class CertLoggerRequest;
@@ -73,6 +77,8 @@ class ErrorReport {
void AddNetworkTimeInfo(
const network_time::NetworkTimeTracker* network_time_tracker);
+ void AddChromeChannel(const version_info::Channel channel);
meacer 2017/06/30 22:24:46 Since this is an enum, you can just pass it withou
sperigo 2017/06/30 23:37:28 Done.
+
// Sets is_retry_upload field of the protobuf to |is_retry_upload|.
void SetIsRetryUpload(bool is_retry_upload);

Powered by Google App Engine
This is Rietveld 408576698