Add chrome channel to cert logger reports

components/certificate_reporting/error_report.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_CERTIFICATE_REPORTING_CERTIFICATE_ERROR_REPORT_H_
 #define COMPONENTS_CERTIFICATE_REPORTING_CERTIFICATE_ERROR_REPORT_H_
 
 #include <memory>
 #include <string>
 
 namespace base {
 class Time;
 }  // namespace base
 
 namespace network_time {
 class NetworkTimeTracker;
 }  // namespace network_time
 
 namespace net {
 class SSLInfo;
 }  // namespace net
 
+namespace version_info {
+enum class Channel;
+}

[meacer, 2017/06/30 22:24:46]

You'll want to include version_info instead of forward declaring it, since it's
passed by value below.

[sperigo, 2017/06/30 23:37:28]

Done.

+
 namespace certificate_reporting {
 
 class CertLoggerRequest;
 
 // This class builds and serializes reports for invalid SSL certificate
 // chains, intended to be sent with ErrorReporter.
 class ErrorReport {
  public:
   // Describes the type of interstitial that the user was shown for the
   // error that this report represents. Gets mapped to
@@ skipping 33 matching lines @@
   bool Serialize(std::string* output) const;
 
   void SetInterstitialInfo(const InterstitialReason& interstitial_reason,
                            const ProceedDecision& proceed_decision,
                            const Overridable& overridable,
                            const base::Time& interstitial_time);
 
   void AddNetworkTimeInfo(
       const network_time::NetworkTimeTracker* network_time_tracker);
 
+  void AddChromeChannel(const version_info::Channel channel);

[meacer, 2017/06/30 22:24:46]

Since this is an enum, you can just pass it without the const. In Chrome value
types are passed without const.

[sperigo, 2017/06/30 23:37:28]

Done.

+
   // Sets is_retry_upload field of the protobuf to |is_retry_upload|.
   void SetIsRetryUpload(bool is_retry_upload);
 
   // Gets the hostname to which this report corresponds.
   const std::string& hostname() const;
 
   // Returns true if the report has been retried.
   bool is_retry_upload() const;
 
  private:
   std::unique_ptr<CertLoggerRequest> cert_report_;
 };
 
 }  // namespace certificate_reporting
 
 #endif  // COMPONENTS_CERTIFICATE_REPORTING_CERTIFICATE_ERROR_REPORT_H_