Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: components/certificate_reporting/cert_logger.proto

Issue 2964283002: Add chrome channel to cert logger reports (Closed)
Patch Set: Clean up test comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/certificate_reporting/cert_logger.proto
diff --git a/components/certificate_reporting/cert_logger.proto b/components/certificate_reporting/cert_logger.proto
index 0d4b7601ca1d0c76b3aa146c99ddba632e2373eb..ea8a7b58ced21aa7c925d792aa9640bc7d3ad519 100644
--- a/components/certificate_reporting/cert_logger.proto
+++ b/components/certificate_reporting/cert_logger.proto
@@ -145,6 +145,18 @@ message CertLoggerRequest {
// user that might affect certificate validation.
optional CertLoggerFeaturesInfo features_info = 10;
+ enum ChromeChannel {
+ NONE = 0;
+ UNKNOWN = 1;
+ DEV = 2;
+ CANARY = 3;
+ BETA = 4;
+ STABLE = 5;
+ };
+
+ // The Chrome channel that this error occurred on.
+ optional ChromeChannel chrome_channel = 12;
+
meacer 2017/06/30 22:24:46 nit: Let's add both the enum and the field after i
sperigo 2017/06/30 23:37:27 Done.
// False when the report is attempted to be uploaded for the first time. True
// in all other uploads.
optional bool is_retry_upload = 11;

Powered by Google App Engine
This is Rietveld 408576698