Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: components/certificate_reporting/cert_logger.proto

Issue 2964283002: Add chrome channel to cert logger reports (Closed)
Patch Set: Clean up test comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This protobuffer is intended to store reports from Chrome users of 5 // This protobuffer is intended to store reports from Chrome users of
6 // certificate errors. A report will be sent from Chrome when it gets 6 // certificate errors. A report will be sent from Chrome when it gets
7 // e.g. a certificate for google.com that chains up to a root CA not expected by 7 // e.g. a certificate for google.com that chains up to a root CA not expected by
8 // Chrome for that origin, such as DigiNotar (compromised in July 2011), or 8 // Chrome for that origin, such as DigiNotar (compromised in July 2011), or
9 // other pinning errors such as a blacklisted cert in the chain, or 9 // other pinning errors such as a blacklisted cert in the chain, or
10 // (when opted in) other certificate validation errors like an expired 10 // (when opted in) other certificate validation errors like an expired
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 // True if the certificate was rooted at a standard CA root ,as opposed to a 138 // True if the certificate was rooted at a standard CA root ,as opposed to a
139 // user-installed root, but is only meaningful if the underlying certificate 139 // user-installed root, but is only meaningful if the underlying certificate
140 // validation library built a trusted chain (i.e. the Chrome net stack set the 140 // validation library built a trusted chain (i.e. the Chrome net stack set the
141 // error, not the library). 141 // error, not the library).
142 optional bool is_issued_by_known_root = 9; 142 optional bool is_issued_by_known_root = 9;
143 143
144 // Information about features that were enabled or disabled for the 144 // Information about features that were enabled or disabled for the
145 // user that might affect certificate validation. 145 // user that might affect certificate validation.
146 optional CertLoggerFeaturesInfo features_info = 10; 146 optional CertLoggerFeaturesInfo features_info = 10;
147 147
148 enum ChromeChannel {
149 NONE = 0;
150 UNKNOWN = 1;
151 DEV = 2;
152 CANARY = 3;
153 BETA = 4;
154 STABLE = 5;
155 };
156
157 // The Chrome channel that this error occurred on.
158 optional ChromeChannel chrome_channel = 12;
159
meacer 2017/06/30 22:24:46 nit: Let's add both the enum and the field after i
sperigo 2017/06/30 23:37:27 Done.
148 // False when the report is attempted to be uploaded for the first time. True 160 // False when the report is attempted to be uploaded for the first time. True
149 // in all other uploads. 161 // in all other uploads.
150 optional bool is_retry_upload = 11; 162 optional bool is_retry_upload = 11;
151 }; 163 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698