Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2964273002: Fix Different default browser breaks webapk affinity. (Closed)

Created:
3 years, 5 months ago by Xi Han
Modified:
3 years, 5 months ago
Reviewers:
Yaron
CC:
chromium-reviews, zpeng+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Different default browser breaks webapk affinity. On L+, when a default browser is set, PackageManager#queryIntentActivities() with flag |PackageManager.MATCH_DEFAULT_ONLY| will return only the ResolvedInfo of the default browser, rather than the ones of all installed browsers. This makes WebApkUtils#getInstalledBrowserResolveInfos() returns wrong resutls. To fix it, we pass in |PackageManager.MATCH_ALL| as flag. BUG=738506 Review-Url: https://codereview.chromium.org/2964273002 Cr-Commit-Position: refs/heads/master@{#483843} Committed: https://chromium.googlesource.com/chromium/src/+/0afceb5ed2c32fcc061e2ad0d8d9df87261d3d46

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/android/webapk/shell_apk/shell_apk_version.gni View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkUtils.java View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Xi Han
Hi Yaron, could you please take a look? Thanks!
3 years, 5 months ago (2017-06-30 20:08:59 UTC) #4
Yaron
lgtm
3 years, 5 months ago (2017-06-30 20:15:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2964273002/20001
3 years, 5 months ago (2017-06-30 21:06:41 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 22:19:13 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0afceb5ed2c32fcc061e2ad0d8d9...

Powered by Google App Engine
This is Rietveld 408576698