Revert of Allow choosing target language in more languages menu(translate infobar)

Revert of Allow choosing target language in more languages menu(translate infobar) (patchset #3 id:60001 of https://codereview.chromium.org/2951963002/ )

Reason for revert:
buildbot failure in chromium.win on Win x64 Builder (dbg)
And crrev.com/2951963002/ is being blamed.
I will revert that CL first although it seems nothing to do with the failure.

buildbot failure URL: https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28dbg%29/builds/55940


Original issue's description:
> Allow choosing target language in more languages menu(translate infobar)
> 
> Allow choosing target language in the source language list.
> 
> 1. When user chooses target language in the source language list,
>    The infobar will dismiss, and no translation takes place.
>    This will not be regarded as a "translation declined" and it
>    will not triggered auto-never or increment the declined counter.
> 
> 2. User still cannot choose source language in target language list.
> 
> BUG=734654
> 
> Review-Url: https://codereview.chromium.org/2951963002
> Cr-Commit-Position: refs/heads/master@{#483906}
> Committed: https://chromium.googlesource.com/chromium/src/+/f1bc64b52ad0ed1ea64baf2e29e37e0bc4575f59

TBR=googleo@chromium.org,mdjones@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=734654

[Marti Wong, 2017-07-01 08:16:29]

The CQ bit was checked by martiw@chromium.org

[Marti Wong, 2017-07-01 08:16:30]

Created Revert of Allow choosing target language in more languages
menu(translate infobar)

[commit-bot: I haz the power, 2017-07-01 08:16:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-01 08:16:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-01 08:16:42]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Marti Wong, 2017-07-01 08:20:27]

The CQ bit was checked by martiw@chromium.org

[commit-bot: I haz the power, 2017-07-01 08:20:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-01 08:20:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-01 08:20:32]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Marti Wong, 2017-07-01 08:40:50]

Description was changed from

==========
Revert of Allow choosing target language in more languages menu(translate
infobar) (patchset #3 id:60001 of https://codereview.chromium.org/2951963002/ )

Reason for revert:
buildbot failure in chromium.win on Win x64 Builder (dbg)
And this is the CL being blamed.
I will revert this CL first although it seems nothing to do with the failure.

Original issue's description:
> Allow choosing target language in more languages menu(translate infobar)
> 
> Allow choosing target language in the source language list.
> 
> 1. When user chooses target language in the source language list,
>    The infobar will dismiss, and no translation takes place.
>    This will not be regarded as a "translation declined" and it
>    will not triggered auto-never or increment the declined counter.
> 
> 2. User still cannot choose source language in target language list.
> 
> BUG=734654
> 
> Review-Url: https://codereview.chromium.org/2951963002
> Cr-Commit-Position: refs/heads/master@{#483906}
> Committed:
https://chromium.googlesource.com/chromium/src/+/f1bc64b52ad0ed1ea64baf2e29e3...

TBR=googleo@chromium.org,mdjones@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=734654
==========

to

==========
Revert of Allow choosing target language in more languages menu(translate
infobar) (patchset #3 id:60001 of https://codereview.chromium.org/2951963002/ )

Reason for revert:
buildbot failure in chromium.win on Win x64 Builder (dbg)
And this is the CL being blamed.
I will revert this CL first although it seems nothing to do with the failure.

buildbot failure URL:
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28d...


Original issue's description:
> Allow choosing target language in more languages menu(translate infobar)
> 
> Allow choosing target language in the source language list.
> 
> 1. When user chooses target language in the source language list,
>    The infobar will dismiss, and no translation takes place.
>    This will not be regarded as a "translation declined" and it
>    will not triggered auto-never or increment the declined counter.
> 
> 2. User still cannot choose source language in target language list.
> 
> BUG=734654
> 
> Review-Url: https://codereview.chromium.org/2951963002
> Cr-Commit-Position: refs/heads/master@{#483906}
> Committed:
https://chromium.googlesource.com/chromium/src/+/f1bc64b52ad0ed1ea64baf2e29e3...

TBR=googleo@chromium.org,mdjones@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=734654
==========

[Marti Wong, 2017-07-01 08:41:56]

Description was changed from

==========
Revert of Allow choosing target language in more languages menu(translate
infobar) (patchset #3 id:60001 of https://codereview.chromium.org/2951963002/ )

Reason for revert:
buildbot failure in chromium.win on Win x64 Builder (dbg)
And this is the CL being blamed.
I will revert this CL first although it seems nothing to do with the failure.

buildbot failure URL:
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28d...


Original issue's description:
> Allow choosing target language in more languages menu(translate infobar)
> 
> Allow choosing target language in the source language list.
> 
> 1. When user chooses target language in the source language list,
>    The infobar will dismiss, and no translation takes place.
>    This will not be regarded as a "translation declined" and it
>    will not triggered auto-never or increment the declined counter.
> 
> 2. User still cannot choose source language in target language list.
> 
> BUG=734654
> 
> Review-Url: https://codereview.chromium.org/2951963002
> Cr-Commit-Position: refs/heads/master@{#483906}
> Committed:
https://chromium.googlesource.com/chromium/src/+/f1bc64b52ad0ed1ea64baf2e29e3...

TBR=googleo@chromium.org,mdjones@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=734654
==========

to

==========
Revert of Allow choosing target language in more languages menu(translate
infobar) (patchset #3 id:60001 of https://codereview.chromium.org/2951963002/ )

Reason for revert:
buildbot failure in chromium.win on Win x64 Builder (dbg)
And crrev.com/2951963002/ is being blamed.
I will revert that CL first although it seems nothing to do with the failure.

buildbot failure URL:
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28d...


Original issue's description:
> Allow choosing target language in more languages menu(translate infobar)
> 
> Allow choosing target language in the source language list.
> 
> 1. When user chooses target language in the source language list,
>    The infobar will dismiss, and no translation takes place.
>    This will not be regarded as a "translation declined" and it
>    will not triggered auto-never or increment the declined counter.
> 
> 2. User still cannot choose source language in target language list.
> 
> BUG=734654
> 
> Review-Url: https://codereview.chromium.org/2951963002
> Cr-Commit-Position: refs/heads/master@{#483906}
> Committed:
https://chromium.googlesource.com/chromium/src/+/f1bc64b52ad0ed1ea64baf2e29e3...

TBR=googleo@chromium.org,mdjones@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=734654
==========

[Marti Wong, 2017-07-01 08:42:08]

martiw@chromium.org changed reviewers:
+ dfalcantara@chromium.org, dominickn@chromium.org, dtrainor@chromium.org,
tedchoc@chromium.org

[Marti Wong, 2017-07-01 08:42:08]

Hi, I need LGTM from a full committer to revert.
thx

[dominickn, 2017-07-01 10:33:26]

On 2017/07/01 08:42:08, Marti Wong wrote:
> Hi, I need LGTM from a full committer to revert.
> thx

This is Java code, which isn't built on Windows at all. The error is:

FAILED: chrome.dll chrome.dll.lib chrome.dll.pdb 
C:/b/depot_tools/python276_bin/python.exe
../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False
link.exe /nologo /IMPLIB:./chrome.dll.lib /DLL /OUT:./chrome.dll
/PDB:./chrome.dll.pdb @./chrome.dll.rsp
LINK : fatal error LNK1181: cannot open input file 'chrome_elf.dll.lib'

I'm guessing the builder ran out of disk space or something. Either way,
reverting this CL is a no-op for that build, so you shouldn't revert (and
possibly assign that bug to infra to investigate).

[Marti Wong, 2017-07-02 04:03:29]

On 2017/07/01 10:33:26, dominickn wrote:
> On 2017/07/01 08:42:08, Marti Wong wrote:
> > Hi, I need LGTM from a full committer to revert.
> > thx
> 
> This is Java code, which isn't built on Windows at all. The error is:
> 
> FAILED: chrome.dll chrome.dll.lib chrome.dll.pdb 
> C:/b/depot_tools/python276_bin/python.exe
> ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False
> link.exe /nologo /IMPLIB:./chrome.dll.lib /DLL /OUT:./chrome.dll
> /PDB:./chrome.dll.pdb @./chrome.dll.rsp
> LINK : fatal error LNK1181: cannot open input file 'chrome_elf.dll.lib'
> 
> I'm guessing the builder ran out of disk space or something. Either way,
> reverting this CL is a no-op for that build, so you shouldn't revert (and
> possibly assign that bug to infra to investigate).

Thanks Dominick, I will close this CL